Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlebars: newline in an attribute incorrectly rendered as [object Object] #8648

Closed
kangax opened this issue Jun 26, 2020 · 3 comments · Fixed by #10145
Closed

Handlebars: newline in an attribute incorrectly rendered as [object Object] #8648

kangax opened this issue Jun 26, 2020 · 3 comments · Fixed by #10145
Labels
lang:handlebars Issues affecting Handlebars (Glimmer) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@kangax
Copy link
Contributor

kangax commented Jun 26, 2020

As reported in jgwhite#1 (comment)

Prettier 2.0.5
Playground link

Input:

<Foo arg="
"/>

Output:

<Foo arg="[object Object]" />

Expected behavior:

<Foo arg="
" />
@thorn0 thorn0 added lang:handlebars Issues affecting Handlebars (Glimmer) type:bug Issues identifying ugly output, or a defect in the program labels Jun 27, 2020
@jelhan
Copy link

jelhan commented Nov 20, 2020

Seems to be fixed in Prettier 2.2.0. At least the Playground link is showing expected output for me.

@kangax
Copy link
Contributor Author

kangax commented Dec 1, 2020

Interesting, ok, closing.

@fisker do you know why this doesn't happen anymore if my PR hasn't gone in yet?

@kangax kangax closed this as completed Dec 1, 2020
@fisker
Copy link
Member

fisker commented Dec 1, 2020

I think this not resolved, but I'm not sure what happened

Prettier 2.2.1
Playground link

--parser glimmer

Input:

<Foo class="
"/>

Output:

<Foo class="[object Object]," />

@fisker fisker reopened this Dec 1, 2020
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang:handlebars Issues affecting Handlebars (Glimmer) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
4 participants