TypeScript as regression (2.0.3)

[sosukesuzuki]

Prettier 2.0.3
Playground link

# Options (if any):
--single-quote

Input:

function foo() {
  return {
    foo,
    foo,    
  } as FOO
}

Output:

function foo() {
  return (
    {
      foo,
      foo,
    } as FOO
  );
}

Expected behavior:

same as input

function foo() {
  return {
    foo,
    foo,    
  } as FOO
}

[sosukesuzuki]

I think we should revert #7869 and implement a handler for TSAsExpression that is different from the one for BinaryExpression.

[thorn0]

The problem arises only if the first operand is an object literal, right? So we rather need to handle this situation as a special case.

[domoritz]

Here are a few more examples where I am seeing this regression in my codebase in case it's helpful.

[domoritz]

Duplicate of #7956?

[thorn0]

@domoritz Could you please paste your examples as code not as screenshots so that we could use them for testing?

[domoritz]

I thought screenshots show the changes well. I merely posted them so you can confirm that these are all "the first operand is an object literal". Let me know which code snippets you want (they are all taken from https://github.com/vega/vega-lite running 2.0.3 vs 2.0.2).

[thorn0]

@domoritz We've already solved this situation. Vega-Lite looks like a good codebase to test new versions of Prettier for regressions before releasing. I've made a note of it.

[domoritz]

Great! typescript-eslint is also using Vega-Lite as a test case: https://github.com/typescript-eslint/typescript-eslint/blob/master/tests/performance/fixtures/lint-real-repo/Dockerfile#L7