Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump flow-parser from 0.121.0 to 0.122.0 #7935

Merged
merged 5 commits into from
Apr 4, 2020
Merged

Bump flow-parser from 0.121.0 to 0.122.0 #7935

merged 5 commits into from
Apr 4, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps flow-parser from 0.121.0 to 0.122.0.

Release notes

Sourced from flow-parser's releases.

v0.122.0

Likely to cause new Flow errors:

  • Moved react-dom modules out of built-in libdefs. They are now available on flow-typed.

    To install the libdefs, run flow-typed install --flow-version=0.122.0 react-dom@16.13.0

    This diff is necessary to allow React to make breaking changes to react-dom without force-pinning Flow users to the latest version of react-dom.

  • Fixed an unsoundness in union and intersection spreads

  • Improved object spread-related error messages, which may cause suppressed errors to become unsuppressed because they moved to better locations

Improved Editor Integration:

  • Removed completion of function param snippets. Before, f<tab> might complete foo(aParam), which is problematic if you don't want to call the function. Now it just completes foo. These snippets are further obviated by signature help, which appears when you type (.
  • Improved accuracy of "Did You Mean?" Quick Fixes for object property type errors
  • Added support for Go to Definition on export-from declarations (export { HERE } from ...)
  • Fixed tracking of open files in LSP clients which could cause stale errors in the IDE

Misc:

  • Added HTMLUnknownElement and support for custom elements to document.createElement (thanks @YevhenKap!)
  • Fixed --saved-state-no-fallback flag so that Flow exits when saved state is not found
  • Fixed an issue where an invalid package.json would prevent generating saved state
  • Fixed a potential deadlock when communicating with Watchman
  • Fixed types-first signatures for CJS requires introduced with var
  • Enabling experimental.types_first now implies experimental.well_formed_exports

Parser:

  • Renamed RestProperty to RestElement to match estree
  • Changed 'for await' nodes from ForAwaitStatement to ForOf with await: true to match estree
Changelog

Sourced from flow-parser's changelog.

0.122.0

Likely to cause new Flow errors:

  • Moved react-dom modules out of built-in libdefs. They are now available on flow-typed.

    To install the libdefs, run flow-typed install --flow-version=0.122.0 react-dom@16.13.0

    This diff is necessary to allow React to make breaking changes to react-dom without force-pinning Flow users to the latest version of react-dom.

  • Fixed an unsoundness in union and intersection spreads

  • Improved object spread-related error messages, which may cause suppressed errors to become unsuppressed because they moved to better locations

Improved Editor Integration:

  • Removed completion of function param snippets. Before, f<tab> might complete foo(aParam), which is problematic if you don't want to call the function. Now it just completes foo. These snippets are further obviated by signature help, which appears when you type (.
  • Improved accuracy of "Did You Mean?" Quick Fixes for object property type errors
  • Added support for Go to Definition on export-from declarations (export { HERE } from ...)
  • Fixed tracking of open files in LSP clients which could cause stale errors in the IDE

Misc:

  • Added HTMLUnknownElement and support for custom elements to document.createElement (thanks @YevhenKap!)
  • Fixed --saved-state-no-fallback flag so that Flow exits when saved state is not found
  • Fixed an issue where an invalid package.json would prevent generating saved state
  • Fixed a potential deadlock when communicating with Watchman
  • Fixed types-first signatures for CJS requires introduced with var
  • Enabling experimental.types_first now implies experimental.well_formed_exports

Parser:

  • Renamed RestProperty to RestElement to match estree
  • Changed 'for await' nodes from ForAwaitStatement to ForOf with await: true to match estree
Commits
  • 1cd1be6 v0.122.0
  • 606f579 [parser] Rename and consolidate RestProperty to RestElement
  • efed734 [lsp] fix tracking of open files on didClose
  • 77bf9b3 [parser] Update 'for await' to use ForOf node with await: true
  • 45d8ae2 Descriptive titles for "did you mean?" quickfixes
  • 598b7bc Don't give quickfixes for object-object casts; only member expressions
  • 91515e7 Add flag to LookupT for whether to give a suggestion upon failure
  • 675c89d [cleanup] simplify restoring packageheap
  • 8247cb7 Simplify typeof_test chain_sense calculation
  • d046a1b Intern comments on expression statements
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Bump flow-parser from 0.121.0 to 0.122.0
31514e1 
Bumps [flow-parser](https://github.com/facebook/flow) from 0.121.0 to 0.122.0.
- [Release notes](https://github.com/facebook/flow/releases)
- [Changelog](https://github.com/facebook/flow/blob/master/Changelog.md)
- [Commits](facebook/flow@v0.121.0...v0.122.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency label Apr 2, 2020
@fisker
Copy link
Member

fisker commented Apr 2, 2020 •
edited

Note:

Parser:

  • Renamed RestProperty to RestElement to match estree
  • Changed 'for await' nodes from ForAwaitStatement to ForOf with await: true to match estree

@alexander-akait
Copy link
Member

alexander-akait commented Apr 2, 2020 •
edited

Coverage is same, but should be less

@sosukesuzuki
Copy link
Member

Probably, we can remove ForAwaitStatement and RestProperty from source code. I'll try it.

alexander-akait
alexander-akait approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@fisker
Copy link
Member

fisker commented Apr 3, 2020 •
edited

Notice this the codecov link on last commit seem not showing coverage about this PR https://codecov.io/gh/prettier/prettier/compare/22e300471989322b913158bbdce118a87a82a0c7...b0ca3bbb6a22a4935ee3294af746cc054b52874c/changes . Maybe there is something wrong .

I was wondering why the coverage didn't change on first commit too.

@sosukesuzuki Can you check/add tests, make sure we have tests for these syntax?

I think we should check all parsers in language-js including __ng__... parser

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Apr 4, 2020 •
edited

@fisker I added the missing tests, but sorry I'm not sure what is wrong with code coverage. How should it be?
or If you can push to this brunch, it's okay to push.

@thorn0
Copy link
Member

thorn0 commented Apr 4, 2020

Our Babel-based coverage reports aren't that smart. Apparently, they don't collect coverage for individual cases.
image
As you can see, only the line 809 is considered covered here. Same with expressions like this:
image
It only checks that the statement was executed.

This probably means we should try avoiding complex expressions if we're interested in catching coverage issues in our code.

@thorn0 thorn0 merged commit 46fc3de into master Apr 4, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/flow-parser-0.122.0 branch April 4, 2020 19:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisker @alexander-akait @sosukesuzuki @thorn0