move react-dom to flow-typed #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
approved these changes
Jan 31, 2020
|
Out of curiosity, what's motivating the move? Edit: pasting discord reply here for reference.
|
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Mar 19, 2020
…ibdefs Summary: This diff removes the react-dom modules out of Flow. They are now available on flow-typed: flow-typed/flow-typed#3716 To install the libdefs, run `flow-typed install --flow-version=0.120.0 react-dom@16.13.0` This diff is necessary to allow React to make breaking changes to react-dom without force-pinning Flow users to the latest version of react-dom. Reviewed By: samwgoldman Differential Revision: D19623320 fbshipit-source-id: 0b9121ce19c696c58fbbd926ce601b1df1c9a947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
This is verbatim the Flow definitions. I also moved the relevant tests to flow-typed.
We're keeping the Synthetic*Event types in Flow for now. We will need to keep the $JSXIntrinsics in Flow forever, since we use that type internally in our type checking.
These types will be moved out of Flow as early as 0.118, but might not make the cut until 0.119.
On the Flow side, I added a test where we have a
flow-typed/npm/react-dom_v16.x.x.jswith this exact definition and I ensure that we have access both to types inreact-dom.jsin Flow andreact-dom_v16.x.x.jsfrom flow-typed.