Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post for 2.0 #7417

Merged
merged 8 commits into from Mar 21, 2020
Merged

Blog post for 2.0 #7417

merged 8 commits into from Mar 21, 2020

Conversation

thorn0
Copy link
Member

@thorn0 thorn0 commented Jan 22, 2020

@kachkaev
Copy link
Member

What's the best way to mention changes in defaults (#6888 (comment))? These are still to be done, but I guess the PRs can land in the last minute.

@sosukesuzuki sosukesuzuki added this to the 2.0 milestone Jan 23, 2020
@sosukesuzuki sosukesuzuki added the status:wip Pull requests that are a work in progress and should not be merged label Jan 23, 2020
@thorn0
Copy link
Member Author

thorn0 commented Jan 23, 2020

@kachkaev There will be a 'Breaking Changes' section in the blog post. But for the PRs to land, someone has to create them. Would you like to help with this?

@kachkaev
Copy link
Member

kachkaev commented Jan 23, 2020

I can give #6929 and #6932 a shot over this weekend. Is this OK with you time-wise?

Guess there is a consensus to not include #6931 into 2.0. I'm happy with that issue being closed. Would you add two others to the milestone if you have access, just so that we don't forget?

@thorn0
Copy link
Member Author

thorn0 commented Jan 23, 2020

I can give #6929 and #6932 a shot over this weekend. Is this OK with you time-wise?

I'll be away this weekend, so yes, sounds good. Please put the changelog entries into changelog_unreleased/api.

@kachkaev
Copy link
Member

Please put the changelog entries into changelog_unreleased/api.

@thorn0 Done. Please see diffs in #7430, #7435 and #7441 🙌

@thorn0 thorn0 force-pushed the blog-post-2.0 branch 6 times, most recently from 67340eb to 17ca7bd Compare February 2, 2020 10:25
{ dir: "yaml", title: "YAML" },
{ dir: "api", title: "API" },
{ dir: "cli", title: "CLI" }
];
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we share this with lint-changelog.js? And I forgot add shebang on lint-changelog.js

Copy link
Member Author

@thorn0 thorn0 Feb 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually it'll be shared, but so far I'm not sure where this script is going to end up. It might become part of the release script or else a page titled "Unreleased changes" might be generated every time the website is built. Or both these options.

@thorn0
Copy link
Member Author

thorn0 commented Feb 2, 2020

Docusaurus's syntax highlighting seems to not understand JS generators: one, two.

@fisker
Copy link
Sponsor Member

fisker commented Feb 2, 2020

highlight.js version?

It's supported, just need another style with different color.

@thorn0
Copy link
Member Author

thorn0 commented Feb 2, 2020

@fisker I bumped highlight.js to the latest version, but it didn't help. Look how it is tokenized:
image
Doesn't look like switching to another theme might help here.

@fisker
Copy link
Sponsor Member

fisker commented Feb 2, 2020

but helps the function* foo one

@thorn0
Copy link
Member Author

thorn0 commented Feb 2, 2020

This one isn't highlighted at all.

website/siteConfig.js Outdated Show resolved Hide resolved
@kachkaev
Copy link
Member

kachkaev commented Feb 15, 2020

👋 @thorn0, what tasks are left to do before the team can release 2.0? How can I help?

@thorn0
Copy link
Member Author

thorn0 commented Feb 16, 2020

@kachkaev As I see it, two tasks are left: #7516, which is a simple revert, and #6776 + #7587, which is a bit trickier than it seems. If you could help with reviewing #7587, would be good.

@fisker
Copy link
Sponsor Member

fisker commented Feb 16, 2020

@thorn0 Are we going to do this #4097 in 2.0?

@thorn0 thorn0 merged commit 8334610 into prettier:next Mar 21, 2020
@thorn0 thorn0 deleted the blog-post-2.0 branch March 21, 2020 20:47
@kachkaev
Copy link
Member

kachkaev commented Mar 21, 2020

@thorn0 many thanks for releasing 2.0, you are a star! 🌟 🙌

One minor thought about the blog post. Shall we replace Prettier stable and Prettier master throughout the examples into something a bit less confusing? Perhaps, Prettier 1.19 and Prettier 2.0 will serve well here. Happy to elaborate more on what I mean.

I can submit a PR with the above corrections if it's a go.

@thorn0
Copy link
Member Author

thorn0 commented Mar 21, 2020

@kachkaev Yes, please. I actually wanted to do this but forgot.

@lydell
Copy link
Member

lydell commented Mar 21, 2020

@kachkaev I used this format for the 1.19 blog post:

// Input
eventStore.update(id, _.flow(updater, incrementVersion));

// Prettier 1.18
eventStore.update(
  id,
  _.flow(
    updater,
    incrementVersion
  )
);

// Prettier 1.19
eventStore.update(id, _.flow(updater, incrementVersion));

@kachkaev
Copy link
Member

kachkaev commented Mar 21, 2020

@thorn0 and @lydell, thanks for your quick replies! See #7819. Hope I haven’t missed or broken anything 🤞

How about adding this versioning step to the Prettier release playbook? Guess it could be done in a separate PR. I don’t know much about your process, so happy to leave this with one of the maintainers 😉

@thorn0
Copy link
Member Author

thorn0 commented Mar 23, 2020

@kachkaev I added this step to https://github.com/prettier/prettier/wiki/Release-Checklist

@kachkaev
Copy link
Member

kachkaev commented Mar 24, 2020

@thorn0 cool!

How about

replace "Prettier stable" and "Prettier master" in code examples with the actual versions

replace "Prettier stable" and "Prettier master" in code examples with the actual versions ([example](https://github.com/prettier/prettier/commit/171bc96b58c0ebad702270389674eadfffec09d1))

The example commit can save from extra questions like Should I write "Prettier 2.x" or "Output (Prettier 2.x)". @lydell’s advice has helped me a lot with this.

@thorn0
Copy link
Member Author

thorn0 commented Mar 24, 2020

@kachkaev ✔ Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:wip Pull requests that are a work in progress and should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants