New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post for 2.0 #7417
Blog post for 2.0 #7417
Conversation
What's the best way to mention changes in defaults (#6888 (comment))? These are still to be done, but I guess the PRs can land in the last minute. |
@kachkaev There will be a 'Breaking Changes' section in the blog post. But for the PRs to land, someone has to create them. Would you like to help with this? |
67340eb
to
17ca7bd
Compare
{ dir: "yaml", title: "YAML" }, | ||
{ dir: "api", title: "API" }, | ||
{ dir: "cli", title: "CLI" } | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we share this with lint-changelog.js
? And I forgot add shebang on lint-changelog.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, eventually it'll be shared, but so far I'm not sure where this script is going to end up. It might become part of the release script or else a page titled "Unreleased changes" might be generated every time the website is built. Or both these options.
It's supported, just need another style with different color. |
@fisker I bumped |
but helps the |
This one isn't highlighted at all. |
👋 @thorn0, what tasks are left to do before the team can release 2.0? How can I help? |
3c5f141
to
782f166
Compare
55247de
to
262423a
Compare
@thorn0 many thanks for releasing 2.0, you are a star! 🌟 🙌 One minor thought about the blog post. Shall we replace I can submit a PR with the above corrections if it's a go. |
@kachkaev Yes, please. I actually wanted to do this but forgot. |
@kachkaev I used this format for the 1.19 blog post: // Input
eventStore.update(id, _.flow(updater, incrementVersion));
// Prettier 1.18
eventStore.update(
id,
_.flow(
updater,
incrementVersion
)
);
// Prettier 1.19
eventStore.update(id, _.flow(updater, incrementVersion)); |
@thorn0 and @lydell, thanks for your quick replies! See #7819. Hope I haven’t missed or broken anything 🤞 How about adding this versioning step to the Prettier release playbook? Guess it could be done in a separate PR. I don’t know much about your process, so happy to leave this with one of the maintainers 😉 |
@kachkaev I added this step to https://github.com/prettier/prettier/wiki/Release-Checklist ✔ |
@thorn0 cool! How about
↓
The example commit can save from extra questions like Should I write "Prettier 2.x" or "Output (Prettier 2.x)". @lydell’s advice has helped me a lot with this. |
@kachkaev ✔ Thanks. |
https://deploy-preview-7417--prettier.netlify.com/blog/2020/03/21/2.0.0.html