Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default values in 2.0 for trailingComma and arrowParens #7806

Closed
simllll opened this issue Mar 21, 2020 · 3 comments
Closed

default values in 2.0 for trailingComma and arrowParens #7806

simllll opened this issue Mar 21, 2020 · 3 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@simllll
Copy link

simllll commented Mar 21, 2020

I updated to prettier#next to test our project with it and also look into the new ts3.8 support ;). Something I discovered that I thought could worth mentioning it, was that even though the docs for 2.x say that trailingComma "none" and arrowParens: "avoid" are the default values, they were not acting like this. I had to set this two parameters explicity in my prettierrc file.
Did the default values change and this is just wrongly documented or is it a bug?

Thanks for prettier!

Simon

@thorn0
Copy link
Member

thorn0 commented Mar 21, 2020

trailingComma "none" and arrowParens: "avoid

In next, the defaults are changed to "trailingComma": "es5", "arrowParens": "always". If you referred to the docs at https://prettier.io/docs/en/next, sorry for the confusion. Those docs are for master, not for next.

Apart from that, what are your impressions of next? Any regressions?

@simllll
Copy link
Author

simllll commented Mar 21, 2020

Ah okay, is there any summary of changes available? So far I cannot find any other issues :-) looks good to me! Looking forward to the release already

@thorn0
Copy link
Member

thorn0 commented Mar 21, 2020

Thanks for testing. See #7417

@thorn0 thorn0 closed this as completed Mar 21, 2020
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jun 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

2 participants