Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): support TS 3.4 #6027

Merged
merged 1 commit into from Apr 4, 2019

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Apr 3, 2019

Fixes #5977

  • add support for readonly operator
  • as const was already supported, added tests to ensure no regression

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang merged commit f4bcb13 into prettier:master Apr 4, 2019
@ikatyang ikatyang deleted the feat/typescript/ts-3.4 branch April 4, 2019 07:33
sqs added a commit to sourcegraph/sourcegraph that referenced this pull request Apr 6, 2019
The new `readonly T[]` operator is quite useful. Prettier's support for it was just merged in prettier/prettier#6027, and it hasn't yet been released, so we need to depend on a Git SHA.
sqs added a commit to sourcegraph/sourcegraph that referenced this pull request Apr 7, 2019
The new `readonly T[]` operator is quite useful. Prettier's support for it was just merged in prettier/prettier#6027, and it hasn't yet been released, so we need to depend on a Git SHA.
@screendriver
Copy link
Contributor

Any chance to get a hotfix release for that @ikatyang? Without that it's not possible to work with TypeScript 3.4 when you want to use readonly Foo[] 😉

@lydell
Copy link
Member

lydell commented Apr 8, 2019

@screendriver A new release is on its way! #5975 (comment)

@screendriver
Copy link
Contributor

Hooray! 🎉 🙌

@brodybits brodybits mentioned this pull request Apr 8, 2019
10 tasks
@ikatyang ikatyang added this to the 1.17 milestone Apr 12, 2019
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TypeScript] support readonly operator
6 participants