Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 Release #5975

Closed
10 tasks
lipis opened this issue Mar 15, 2019 · 7 comments · Fixed by #6052
Closed
10 tasks

1.17 Release #5975

lipis opened this issue Mar 15, 2019 · 7 comments · Fixed by #6052
Assignees
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Milestone

Comments

@lipis
Copy link
Member

lipis commented Mar 15, 2019

Then monitor Twitter/GitHub for any immediate issues 😅

@lipis lipis added this to the 1.17 milestone Mar 15, 2019
@ntotten
Copy link
Member

ntotten commented Mar 29, 2019

Any chance we can remove #3888 from this release? It seems like that is holding things up as it is very controversial. There are a number of fixes and a new parser (LWC) in this release that would be great to go out soon.

@lydell
Copy link
Member

lydell commented Mar 29, 2019

Sounds reasonable!

@ntotten
Copy link
Member

ntotten commented Apr 8, 2019

@ikatyang Any chance this release could go out. It looks like all the PRs are closed and all issues are resolved except #3888 which doesn't seem to have a conclusion. We would love to get the LWC parser into a release ASAP. :)

@duailibe
Copy link
Member

duailibe commented Apr 8, 2019

@ntotten I'm already working on it

@duailibe duailibe self-assigned this Apr 8, 2019
@brodybits
Copy link
Contributor

I was hoping the dependency updates I proposed in approved PRs #5985 & #5987 would be included.

@brodybits
Copy link
Contributor

S.o.r.r.y to be a pain here ... I forgot to mention that I think that the test in #5989 should be included if possible. It is needed to ensure that issue #5817 which was solved by TypeScript 3.4 update (#6027) does not reappear and can be closed.

Kudos to @ntotten and @duailibe for pushing this to go out the door.

@ikatyang ikatyang pinned this issue Apr 12, 2019
@duailibe duailibe unpinned this issue Apr 12, 2019
@ntotten
Copy link
Member

ntotten commented Apr 12, 2019

Awesome. Thanks everyone for getting this out!

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants