Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test generics in object methods in TypeScript #5989

Merged
merged 1 commit into from Apr 8, 2019
Merged

Test generics in object methods in TypeScript #5989

merged 1 commit into from Apr 8, 2019

Conversation

brodybits
Copy link
Contributor

@brodybits brodybits commented Mar 19, 2019 •
edited

Test generics in object methods in TypeScript, as proposed by @j-f1 in PR #5824 to verify that #5817 is resolved and does not reappear in the future

Changes removed since they are no longer needed:

  • I verified that this update gives me a green build on Azure Pipelines - verified still green after my rebase
  • I’ve added tests to confirm my change works the recent update in f4bcb13 resolves the issue described in TypeScript generics are removed incorrectly #5817.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template. removed since the needed update was already applied
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@brodybits brodybits marked this pull request as ready for review March 19, 2019 18:31
@brodybits brodybits force-pushed the tslint-typescript-estree-fix branch from c37e21d to 2d2ae11 Compare March 19, 2019 18:35
@alexander-akait
Copy link
Member

/cc @brodybits can you rebase?

@brodybits brodybits force-pushed the tslint-typescript-estree-fix branch 2 times, most recently from a67c315 to ecdc825 Compare April 4, 2019 20:14
@brodybits
Copy link
Contributor Author

/cc @brodybits can you rebase?

Done, but only the test case remains. I already updated the description, will give some more info after I update the title.

@brodybits brodybits changed the title @typescript-eslint/typescript-estree 1.4.2 fix Test generics in object methods in TypeScript Apr 4, 2019
@brodybits
Copy link
Contributor Author

brodybits commented Apr 4, 2019 •
edited

The originally proposed update is no longer needed since it is superseded by an even newer update of @typescript-eslint/typescript-estree in merged PR #6027. I think this means that issue #5817 is resolved and should be closed.

I think the new test case, which was authored by @j-f1 as part of PR #5824 and proposed in this PR, should be merged to verify that the resolved bug #5817 does not reappear in the future.

P.S. I did yet a couple more force-pushes so that the commit message would automatically close the following:

@brodybits brodybits force-pushed the tslint-typescript-estree-fix branch from ecdc825 to 86912ff Compare April 4, 2019 20:38
@brodybits brodybits mentioned this pull request Apr 4, 2019
Closed
@j-f1
Test generics in object methods in TypeScript
716b8b4 
as proposed by @j-f1 in the following PR: prettier#5824

should validate that issue prettier#5817 does not reappear

this change closes prettier#5817 as resolved and tested

this change closes prettier#5824 (PR prettier#5824) as superseded

Co-authored-by: Jed Fox <git@twopointzero.us>
Co-authored-by: Christopher J. Brody <chris@brody.consulting>
@brodybits brodybits force-pushed the tslint-typescript-estree-fix branch from 86912ff to 716b8b4 Compare April 4, 2019 20:45
This was referenced Apr 4, 2019
Closed
Closed
@duailibe
Copy link
Member

duailibe commented Apr 8, 2019

Closes #5817

@duailibe duailibe merged commit 6ae4106 into prettier:master Apr 8, 2019
@duailibe
Copy link
Member

duailibe commented Apr 8, 2019

Yeah I should've known that doesn't work 😝

@brodybits brodybits deleted the tslint-typescript-estree-fix branch April 8, 2019 19:58
@brodybits
Copy link
Contributor Author

I think PR #5824 should be closed as well, since it was superseded by this proposal.

I wonder if we should have updated the changelog for #6027 (TypeScript 3.4) since it fixes the bug in #5817?

@duailibe
Copy link
Member

duailibe commented Apr 8, 2019

@brodybits that bug is fixed since 1.16.3

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brodybits @alexander-akait @duailibe