Skip to content

Commit

Permalink
Consistently quote Sass modules strings
Browse files Browse the repository at this point in the history
Fixes #11053.
  • Loading branch information
niksy committed Sep 7, 2021
1 parent bf2a24f commit 38e427d
Show file tree
Hide file tree
Showing 5 changed files with 81 additions and 1 deletion.
42 changes: 42 additions & 0 deletions changelog_unreleased/scss/11461.md
@@ -0,0 +1,42 @@
<!--
1. Choose a folder based on which language your PR is for.
- For JavaScript, choose `javascript/` etc.
- For TypeScript specific syntax, choose `typescript/`.
- If your PR applies to multiple languages, such as TypeScript/Flow, choose one folder and mention which languages it applies to.
2. In your chosen folder, create a file with your PR number: `XXXX.md`. For example: `typescript/6728.md`.
3. Copy the content below and paste it in your new file.
4. Fill in a title, the PR number and your user name.
5. Optionally write a description. Many times it’s enough with just sample code.
6. Change ```jsx to your language. For example, ```yaml.
7. Change the `// Input` and `// Prettier` comments to the comment syntax of your language. For example, `# Input`.
8. Choose some nice input example code. Paste it along with the output before and after your PR.
-->

#### Consistently quote Sass modules strings (#11461 by @niksy)

<!-- Optional description if it makes sense. -->

<!-- prettier-ignore -->
```scss
// Input
@use "sass:math";
@forward "list";

// Prettier stable
@use "sass:math";
@forward "list";

// Prettier main
@use 'sass:math';
@forward 'list';
```
2 changes: 1 addition & 1 deletion src/language-css/parser-postcss.js
Expand Up @@ -525,7 +525,7 @@ function parseNestedCSS(node, options) {
return node;
}

if (lowercasedName === "import") {
if (["import", "use", "forward"].includes(lowercasedName)) {
node.import = true;
delete node.filename;
node.params = parseValue(params, options);
Expand Down
34 changes: 34 additions & 0 deletions tests/format/scss/quotes/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,34 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`quotes.scss - {"singleQuote":true} format 1`] = `
====================================options=====================================
parsers: ["scss"]
printWidth: 80
singleQuote: true
| printWidth
=====================================input======================================
@use "module";
@forward "module";
=====================================output=====================================
@use 'module';
@forward 'module';
================================================================================
`;

exports[`quotes.scss format 1`] = `
====================================options=====================================
parsers: ["scss"]
printWidth: 80
| printWidth
=====================================input======================================
@use "module";
@forward "module";
=====================================output=====================================
@use "module";
@forward "module";
================================================================================
`;
2 changes: 2 additions & 0 deletions tests/format/scss/quotes/jsfmt.spec.js
@@ -0,0 +1,2 @@
run_spec(__dirname, ["scss"]);
run_spec(__dirname, ["scss"], { singleQuote: true });
2 changes: 2 additions & 0 deletions tests/format/scss/quotes/quotes.scss
@@ -0,0 +1,2 @@
@use "module";
@forward "module";

0 comments on commit 38e427d

Please sign in to comment.