disable optimization from #6229 for calls with type arguments (#6791)

prettier · Nov 3, 2019 · 12ba997 · 12ba997
1 parent 677b46d
commit 12ba997
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js
@@ -4024,7 +4024,9 @@ function printArgumentsList(path, options, print) {
       somePrintedArgumentsWillBreak ? breakParent : "",
       conditionalGroup(
         [
-          !somePrintedArgumentsWillBreak
+          !somePrintedArgumentsWillBreak &&
+          !node.typeArguments &&
+          !node.typeParameters
             ? simpleConcat
             : ifBreak(allArgsBrokenOut(), simpleConcat),
           shouldGroupFirst

diff --git a/tests/break-calls/__snapshots__/jsfmt.spec.js.snap b/tests/break-calls/__snapshots__/jsfmt.spec.js.snap
@@ -231,3 +231,23 @@ function MyComponent(props) {
 
 ================================================================================
 `;
+
+exports[`type_args.js 1`] = `
+====================================options=====================================
+parsers: ["flow", "typescript"]
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+const response = something.$http.get<ThingamabobService.DetailsData>(
+  \`api/foo.ashx/foo-details/\${myId}\`,
+  { cache: quux.httpCache, timeout }
+);
+
+=====================================output=====================================
+const response = something.$http.get<ThingamabobService.DetailsData>(
+  \`api/foo.ashx/foo-details/\${myId}\`,
+  { cache: quux.httpCache, timeout }
+);
+
+================================================================================
+`;
diff --git a/tests/break-calls/type_args.js b/tests/break-calls/type_args.js
@@ -0,0 +1,4 @@
+const response = something.$http.get<ThingamabobService.DetailsData>(
+  `api/foo.ashx/foo-details/${myId}`,
+  { cache: quux.httpCache, timeout }
+);