Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description of vueIndentScriptAndStyle option #2775

Merged
merged 5 commits into from Jan 11, 2023
Merged

Update description of vueIndentScriptAndStyle option #2775

merged 5 commits into from Jan 11, 2023

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Nov 2, 2022 •
edited

Sync with Prettier website. prettier/prettier#13781

Remove sentence that may affect decision making, and "祖师爷" is also an improper word to use here.

"祖师爷" is an improper word to use here.

  • Run tests
  • Update the CHANGELOG.md with a summary of your changes

@auto-assign auto-assign bot requested a review from ntotten November 2, 2022 07:17
@fisker fisker marked this pull request as draft November 2, 2022 07:28
@fisker

This comment was marked as outdated.

Sign in to view
@fisker fisker changed the title Update Chinese translation Update description of vueIndentScriptAndStyle option Nov 4, 2022
@fisker fisker marked this pull request as ready for review November 4, 2022 03:16
sxzz
sxzz approved these changes Jan 8, 2023
View reviewed changes
Copy link

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for blocking this PR?

@Mrbunker
Copy link
Contributor

I made a mistake, the translation is bad.
It needs to be updated, can you merge it? @ntotten

@ntotten ntotten merged commit bd6d34e into prettier:main Jan 11, 2023
@fisker fisker deleted the lang branch January 11, 2023 18:07
@fisker fisker mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@ntotten ntotten Awaiting requested review from ntotten

Assignees

@ntotten ntotten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisker @Mrbunker @sxzz @ntotten