New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate semantic-release
to changesets
#443
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
5ff5a21
to
1ec296a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the uninitiated, will you add more to the changesets readme on how we should go about releasing?
Sure, thanks for reminding! @kylemh Done! |
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 165 165
Branches 27 27
=========================================
Hits 165 165 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
semantic-release
to changesets
There is an issue with using Might be worth replacing with |
Thanks for pointing it out, but I didn't meat this issue previously. Of it occurrs, we can try to align. |
Now, I think the GitHub's default behavior is a very good feature, a PR generated by changesets do not need to run CI tasks IMO, they just remove changesets files, change |
I see what you mean. Not running GitHub Actions for ‘Version packages’ PR will save some compute time indeed. There is pretty much zero chance for those checks to fail, so not running them may make sense. The situation changes if at least one PR check is required: This will block the merge button. This repo does not seem to have any required PR checks, so using |
I met this situation previously indeed, and it's a @github's production issue IMO. |
What: close #441
Why: Using
semantic-release
is really a bad experience to me these days...How: implemented