Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate semantic-release to changesets #443

Merged
merged 3 commits into from Aug 24, 2022
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Aug 24, 2022

What: close #441

Why: Using semantic-release is really a bad experience to me these days...

How: implemented

@JounQin JounQin added dependencies Pull requests that update a dependency file internal This affects the hidden internals labels Aug 24, 2022
@JounQin JounQin self-assigned this Aug 24, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2022

⚠️ No Changeset found

Latest commit: 9e70124

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

package.json Show resolved Hide resolved
Copy link
Collaborator

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the uninitiated, will you add more to the changesets readme on how we should go about releasing?

@JounQin
Copy link
Member Author

JounQin commented Aug 24, 2022

For the uninitiated, will you add more to the changesets readme on how we should go about releasing?

Sure, thanks for reminding!


@kylemh Done!

@codecov-commenter
Copy link

Codecov Report

Merging #443 (1ec296a) into master (3eef076) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ec296a differs from pull request most recent head b80e046. Consider uploading reports for the commit b80e046 to get more accurate results

@@            Coverage Diff            @@
##            master      #443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          165       165           
  Branches        27        27           
=========================================
  Hits           165       165           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JounQin JounQin requested a review from kylemh August 24, 2022 12:28
@JounQin JounQin changed the title ci: migrate semantic-release to changesets ci: migrate semantic-release to changesets Aug 24, 2022
@JounQin JounQin merged commit e4ad84f into master Aug 24, 2022
@JounQin JounQin deleted the chore/changesets branch August 24, 2022 14:28
@kachkaev
Copy link
Member

kachkaev commented Aug 24, 2022

There is an issue with using secrets.GITHUB_TOKEN and Changesets: changesets/action#187 (comment)

Might be worth replacing with secrets.CUSTOM_GITHUB_TOKEN in a follow-up PR.

@JounQin
Copy link
Member Author

JounQin commented Aug 24, 2022

There is an issue with using secrets.GITHUB_TOKEN and Changesets: changesets/action#187 (comment)

Might be worth replacing with secrets.CUSTOM_GITHUB_TOKEN in a follow-up PR.

Thanks for pointing it out, but I didn't meat this issue previously. Of it occurrs, we can try to align.

@JounQin
Copy link
Member Author

JounQin commented Aug 25, 2022

There is an issue with using secrets.GITHUB_TOKEN and Changesets: changesets/action#187 (comment)

Might be worth replacing with secrets.CUSTOM_GITHUB_TOKEN in a follow-up PR.

@kachkaev

Now, I think the GitHub's default behavior is a very good feature, a PR generated by changesets do not need to run CI tasks IMO, they just remove changesets files, change CHANGELOG.md and update package.json, there seems nothing to check on CI, HDYT?

@kachkaev
Copy link
Member

I see what you mean. Not running GitHub Actions for ‘Version packages’ PR will save some compute time indeed. There is pretty much zero chance for those checks to fail, so not running them may make sense.

The situation changes if at least one PR check is required:

Screenshot 2022-08-25 at 12 09 20

This will block the merge button.

This repo does not seem to have any required PR checks, so using CUSTOM_GITHUB_TOKEN does not seem necessary, at least for now.

@JounQin
Copy link
Member Author

JounQin commented Aug 25, 2022

The situation changes if at least one PR check is required

I met this situation previously indeed, and it's a @github's production issue IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal This affects the hidden internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintainace: replace semantic-release with changesets
4 participants