Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): migrate messageformat to @messageformat/core #442

Merged
merged 4 commits into from Aug 23, 2022
Merged

fix(deps): migrate messageformat to @messageformat/core #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9f5073
deps: Update messageformat
Aug 21, 2022
0f34752
Update messages.js
Aug 21, 2022
bd27e7a
fix(deps): reorder dependencies
JounQin Aug 23, 2022
1d7745f
test: update snapshot (unexpected from ajv)
JounQin Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -35,6 +35,7 @@
}
},
"dependencies": {
"@messageformat/core": "^3.0.1",
"@prettier/eslint": "npm:prettier-eslint@^15.0.1",
"arrify": "^2.0.1",
"boolify": "^1.0.1",
Expand All @@ -50,7 +51,6 @@
"indent-string": "^4.0.0",
"lodash.memoize": "^4.1.2",
"loglevel-colored-level-prefix": "^1.0.0",
"messageformat": "^2.3.0",
"rxjs": "^7.5.6",
"yargs": "^13.1.1"
},
Expand Down
2 changes: 1 addition & 1 deletion src/messages.js
View file
Open in desktop
@@ -1,4 +1,4 @@
import MessageFormat from 'messageformat';
import MessageFormat from '@messageformat/core';

const mf = new MessageFormat('en');

Expand Down
6 changes: 5 additions & 1 deletion test/tests/__snapshots__/cli.spec.js.snap
View file
Open in desktop
Expand Up @@ -17,6 +17,10 @@ Object {
`;

exports[`prettier-eslint test/fixtures/example*.js --write --no-eslint-ignore --no-prettier-ignore: stdout: prettier-eslint test/fixtures/example*.js --write --no-eslint-ignore --no-prettier-ignore 1`] = `
"success formatting 2 files with prettier-eslint
"can't resolve reference #/definitions/directiveConfigSchema from id #
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These warnings come from ajv which is very unexpected...

can't resolve reference #/definitions/directiveConfigSchema from id #
can't resolve reference #/definitions/directiveConfigSchema from id #
can't resolve reference #/definitions/directiveConfigSchema from id #
success formatting 2 files with prettier-eslint
"
`;