fix(deps): migrate messageformat to @messageformat/core
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2022 14:35
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 165 165
Branches 27 27
=========================================
Hits 165 165
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JounQin
approved these changes
Aug 21, 2022
|
Sorry, forgive me for asking when this PR can be merged, or is there anything else to do? |
JounQin
changed the title
messageformatmessageformat to @messageformat/core
JounQin
reviewed
Aug 23, 2022
| @@ -17,6 +17,10 @@ Object { | |||
| `; | |||
|
|
|||
| exports[`prettier-eslint test/fixtures/example*.js --write --no-eslint-ignore --no-prettier-ignore: stdout: prettier-eslint test/fixtures/example*.js --write --no-eslint-ignore --no-prettier-ignore 1`] = ` | |||
| "success formatting 2 files with prettier-eslint | |||
| "can't resolve reference #/definitions/directiveConfigSchema from id # | |||
There was a problem hiding this comment.
These warnings come from ajv which is very unexpected...
JounQin
changed the title
messageformat to @messageformat/coremessageformat to @messageformat/core
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@lihe07 Thanks for your contribution! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package: messageformat has recently been renamed as '@messageformat/core`
My pnpm is noticing me for this change. If you don't mind, can you merge this PR? This way I can freely use
prettier-eslint-cliin my projects.