Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to changeset for automatically releasing #278

Merged
merged 1 commit into from Jan 14, 2024

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 14, 2024

close #277

Copy link

changeset-bot bot commented Jan 14, 2024

⚠️ No Changeset found

Latest commit: 7f261f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lydell
Copy link
Member

lydell commented Jan 14, 2024

Hi!

I don’t want to review. I trust you with this stuff.

Btw, if you wondered what package-real.json was for: I got obsessed with making npm packages smaller, so I generated a smaller package.json without all the crap that doesn’t matter in an npm package (scripts, devDependencies). That’s also why I truncated the readme file – I personally never read readmes on npmjs.com since they are always out of date. eslint-config-prettier has a lot of downloads, so we quickly reach terabytes of wasted bytes. (I didn’t minify the code, since that makes debugging and auditing harder.) But these things are up to you now.

@lydell lydell removed their request for review January 14, 2024 08:53
@JounQin
Copy link
Member Author

JounQin commented Jan 14, 2024

@lydell

I know what does the real file do, I've changed to use clean-pkg-json for this purpose.

For readme, I think it helps to read on npmjs or in node_modules directly.

Small size is great, but I think that doesn't need to be so strict.

Cheers. 🍻

@lydell
Copy link
Member

lydell commented Jan 14, 2024

Thanks for sharing clean-pkg-json! Looks great.

Regarding the readme: I find it kind of ironic that the readme is almost twice as big as index.js + bin/* 😄 But again, it’s up to you.

@JounQin
Copy link
Member Author

JounQin commented Jan 14, 2024

I'll merge this PR as-is then.

@JounQin JounQin merged commit 5687e7d into main Jan 14, 2024
10 checks passed
@JounQin JounQin deleted the chore/changesets branch January 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maintenance: use changesets for releasing automatically
2 participants