Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable @typescript-eslint/space-before-function-paren rule #125

Merged
merged 1 commit into from Nov 19, 2019
Merged

Disable @typescript-eslint/space-before-function-paren rule #125

merged 1 commit into from Nov 19, 2019

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented Nov 19, 2019

The new rule @typescript-eslint/space-before-function-paren has been added since @typescript-eslint/eslint-plugin@2.8.0.

This rule is an extension of the ESLint core rule space-before-function-paren,
and eslint-config-prettier has disabled the rule already.

The new rule `@typescript-eslint/space-before-function-paren` has been added since `@typescript-eslint/eslint-plugin@2.8.0`.

- https://github.com/typescript-eslint/typescript-eslint/blob/v2.8.0/packages/eslint-plugin/docs/rules/space-before-function-paren.md
- https://github.com/typescript-eslint/typescript-eslint/releases/tag/v2.8.0
- typescript-eslint/typescript-eslint#924

This rule is an extension of the ESLint core rule `space-before-function-paren`,
and `eslint-config-prettier` has disabled the rule already.

- https://github.com/prettier/eslint-config-prettier/blob/ed97c2f4cb77b5cc8cb941900b81304b5cd6eb1d/index.js#L77
@ybiquitous ybiquitous marked this pull request as ready for review November 19, 2019 01:23
@lydell lydell merged commit ba67d5d into prettier:master Nov 19, 2019
@lydell
Copy link
Member

lydell commented Nov 19, 2019

Thanks! Released in v6.7.0.

@ybiquitous ybiquitous deleted the disable-typescript-space-before-function-paren branch November 19, 2019 06:23
@ybiquitous
Copy link
Contributor Author

@lydell I always appreciate your quick feedback! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants