Skip to content

Commit

Permalink
Disable @typescript-eslint/space-before-function-paren rule (#125)
Browse files Browse the repository at this point in the history
The new rule `@typescript-eslint/space-before-function-paren` has been added since `@typescript-eslint/eslint-plugin@2.8.0`.

- https://github.com/typescript-eslint/typescript-eslint/blob/v2.8.0/packages/eslint-plugin/docs/rules/space-before-function-paren.md
- https://github.com/typescript-eslint/typescript-eslint/releases/tag/v2.8.0
- typescript-eslint/typescript-eslint#924

This rule is an extension of the ESLint core rule `space-before-function-paren`,
and `eslint-config-prettier` has disabled the rule already.

- https://github.com/prettier/eslint-config-prettier/blob/ed97c2f4cb77b5cc8cb941900b81304b5cd6eb1d/index.js#L77
  • Loading branch information
ybiquitous authored and lydell committed Nov 19, 2019
1 parent ed97c2f commit ba67d5d
Show file tree
Hide file tree
Showing 4 changed files with 52 additions and 22 deletions.
1 change: 1 addition & 0 deletions @typescript-eslint.js
Expand Up @@ -10,6 +10,7 @@ module.exports = {
"@typescript-eslint/member-delimiter-style": "off",
"@typescript-eslint/no-extra-parens": "off",
"@typescript-eslint/semi": "off",
"@typescript-eslint/space-before-function-paren": "off",
"@typescript-eslint/type-annotation-spacing": "off"
}
};
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -798,7 +798,7 @@ eslint-config-prettier has been tested with:
- eslint-config-prettier 2.10.0 and older were tested with ESLint 4.x
- eslint-config-prettier 2.1.1 and older were tested with ESLint 3.x
- prettier 1.19.1
- @typescript-eslint/eslint-plugin 2.7.0
- @typescript-eslint/eslint-plugin 2.8.0
- eslint-plugin-babel 5.3.0
- eslint-plugin-flowtype 4.4.1
- eslint-plugin-react 7.16.0
Expand Down
67 changes: 48 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -39,8 +39,8 @@
"get-stdin": "^6.0.0"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "2.7.0",
"@typescript-eslint/parser": "2.7.0",
"@typescript-eslint/eslint-plugin": "2.8.0",
"@typescript-eslint/parser": "2.8.0",
"babel-eslint": "10.0.3",
"cross-spawn": "6.0.5",
"doctoc": "1.4.0",
Expand Down

0 comments on commit ba67d5d

Please sign in to comment.