Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copying Sexps that are too large #1820

Merged
merged 1 commit into from Jan 26, 2024

Conversation

presidentbeef
Copy link
Owner

Addresses #1816, #1546, maybe others.

I avoided doing this in the past, because checking the size of the s-exps all the time seemed expensive. However, based on some testing, it has little to no impact on scan times. Caching the s-sexp mass doesn't make much of a difference.

On the other hand, it resolves some performance issues and doesn't appear to reduce useful results.

If needed, the mass limit can be adjusted by using a config file. Not adding a command line option at this time.

Copy link

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
AI-powered Sensitive Function Check
Configured Sensitive Files Check
AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@presidentbeef presidentbeef merged commit f07829d into main Jan 26, 2024
12 checks passed
@presidentbeef presidentbeef deleted the limit_mass_of_copied_values branch January 26, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant