fix(InteractiveIgnorer): use FilePath #1624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1623 reverted the cause of the issue. |
Repository owner
locked and limited conversation to collaborators
Jan 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1622.
The refactor of ignore files to use FilePath in #1620 did not include
the InteractiveIgnorer. Complete the refactor.
The original PR included the refactor to FilePath in order to update
ignorefile pathing to match other pathing within Brakeman, which in turn
permitted the SARIF report to use the pre-loaded relative path in its
output.
As noted in #1622, this had the unintended side effect of making the
path of
-iconfigurations relative to the app root (if an absolutepath was not provided), rather than relative to where the command was
run. This differs from the behavior of the
-cflag, may beundesired, and is not addressed in this PR.