Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor: IgnoreConfig uses FilePath" #1623

Merged
merged 1 commit into from Jul 20, 2021
Merged

Revert "refactor: IgnoreConfig uses FilePath" #1623

merged 1 commit into from Jul 20, 2021

Commits on Jul 19, 2021

  1. Revert "refactor: IgnoreConfig uses FilePath" 

    This reverts commit 52bfc9b.

It seems that this might break --interactive-ignore. Specifically on
line 39 of lib/brakeman/report/interactive.rb.

https://github.com/presidentbeef/brakeman/blob/53db6f585679f648ce761421a9eba2e02e18a4a1/lib/brakeman/report/ignore/interactive.rb#L39

When asking for the ignore file location `@ignore_config.file` is
checked for emptiness but Brakeman::FilePath has no `empty?` method and
so this fails.
    @bradparker
    bradparker committed Jul 19, 2021
    Copy the full SHA
    d517c99 View commit details
    Browse the repository at this point in the history