Support fetch from both arrays and hashes
#1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presidentbeef
force-pushed
the
array_hash_fetch
branch
from
3257310
to
6c1d8bc
Compare
Repository owner
locked and limited conversation to collaborators
Jan 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fetch values from arrays/hashes based on key provided in
fetch, if possible. But does not use the default value.If the array or hash has all literal values but the key is unknown (e.g. a variable we don't know the value of), returns a safe literal instead. This was already in place for
Hash#[]but somehow notArray#[]馃Fixes one of the issues from #1571