Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] haml dependency #1043

Closed
wants to merge 1 commit into from
Closed

[update] haml dependency #1043

wants to merge 1 commit into from

Conversation

joshRpowell
Copy link

@presidentbeef
Copy link
Owner

Brakeman depends on the internal compiler output of Haml/Slim/ERB, so updates like this are problematic.

Brakeman also bundles all dependencies. So unless there is a Haml 5.0 feature you are using that doesn't work in Haml 4.0 or you are using brakeman-lib, there is no need to upgrade immediately.

@joshRpowell
Copy link
Author

@presidentbeef thanks for breakman and the quick response.
Nothing urgent in 5.0 that we can't workaround on our end.
I'll close the PR and leave #1044 open for reference.
Thank again!

@joshRpowell joshRpowell closed this May 9, 2017
@presidentbeef
Copy link
Owner

What issues are you having to work around? Haml 5.0 features?

Repository owner locked and limited conversation to collaborators Jul 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants