Ensure RubyParser is passed path as a string

Fixes #1534
presidentbeef · Dec 23, 2020 · c73f314 · c73f314
1 parent f09d161
commit c73f314
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/brakeman/file_parser.rb b/lib/brakeman/file_parser.rb
@@ -33,7 +33,12 @@ def read_files list, type
       end
     end
 
+    # _path_ can be a string or a Brakeman::FilePath
     def parse_ruby input, path
+      if path.is_a? Brakeman::FilePath
+        path = path.relative
+      end
+
       begin
         Brakeman.debug "Parsing #{path}"
         RubyParser.new.parse input, path, @timeout

diff --git a/test/tests/file_parser.rb b/test/tests/file_parser.rb
@@ -28,4 +28,14 @@ def test_parse_error_shows_newer_failure
       assert_match(/parse error on value \"\$end\" \(\$end\)/, @tracker.errors.first[:error])
     end
   end
+
+  def test_parse_ruby_accepts_file_path
+    file_path = Brakeman::FilePath.from_app_tree @tracker.app_tree, "config/test.rb"
+
+    parsed = @file_parser.parse_ruby <<-'RUBY', file_path
+      "#{__FILE__}"
+    RUBY
+
+    assert_equal s(:str, "config/test.rb"), parsed
+  end
 end