Skip to content

Commit

Permalink
fix: Allow setting ingress hosts directly through yaml (apache#23446)
Browse files Browse the repository at this point in the history
Co-authored-by: josh.paulin <josh.paulin@wheniwork.com>
  • Loading branch information
paulinjo and josh.paulin committed Mar 22, 2023
1 parent 8588f81 commit 499754a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion helm/superset/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ maintainers:
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
version: 0.8.7
version: 0.8.8
dependencies:
- name: postgresql
version: 12.1.6
Expand Down
3 changes: 2 additions & 1 deletion helm/superset/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs

# superset

![Version: 0.8.7](https://img.shields.io/badge/Version-0.8.7-informational?style=flat-square)
![Version: 0.8.8](https://img.shields.io/badge/Version-0.8.8-informational?style=flat-square)

Apache Superset is a modern, enterprise-ready business intelligence web application

Expand Down Expand Up @@ -74,6 +74,7 @@ helm install my-superset superset/superset
| imagePullSecrets | list | `[]` | |
| ingress.annotations | object | `{}` | |
| ingress.enabled | bool | `false` | |
| ingress.extraHostsRaw | list | `[]` | |
| ingress.hosts[0] | string | `"chart-example.local"` | |
| ingress.path | string | `"/"` | |
| ingress.pathType | string | `"ImplementationSpecific"` | |
Expand Down
6 changes: 6 additions & 0 deletions helm/superset/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ spec:
{{- end }}
{{- end }}
rules:
{{- if .Values.ingress.extraHostsRaw }}
{{- toYaml .Values.extraEnvRaw | nindent 12 }}
{{- end }}
{{- range .Values.ingress.hosts }}
- host: {{ . }}
http:
Expand All @@ -66,4 +69,7 @@ spec:
name: ws
{{- end }}
{{- end }}
{{- if .Values.ingress.extraHostsRaw }}
{{- toYaml .Values.ingress.extraHostsRaw | nindent 4 }}
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions helm/superset/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ ingress:
hosts:
- chart-example.local
tls: []
extraHostsRaw: []
# - secretName: chart-example-tls
# hosts:
# - chart-example.local
Expand Down

0 comments on commit 499754a

Please sign in to comment.