Use File.read instead of IO.read #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If argument starts with a pipe character (`'|'`) and the receiver is the `IO` class, a subprocess is created in the same way as `Kernel#open`, and its output is returned. `Kernel#open` may allow unintentional command injection, which is the reason these `IO` methods are a security risk. Consider to use `File.read` to disable the behavior of subprocess invocation. Ref: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/IoMethods
|
nice find! |
|
1.17.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If argument starts with a pipe character (
'|') and the receiver is theIOclass, a subprocess is created in the same way asKernel#open, and its output is returned.Kernel#openmay allow unintentional command injection, which is the reason theseIOmethods are a security risk. Consider to useFile.readto disable the behavior of subprocess invocation.Ref: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/IoMethods
Why and what is being done.
Pre-Merge Checklist