Add typeModule experimental flag
#586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 715fa60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 92.15% 92.38% +0.22%
==========================================
Files 39 39
Lines 1951 2049 +98
Branches 571 625 +54
==========================================
+ Hits 1798 1893 +95
- Misses 143 146 +3
Partials 10 10 ☔ View full report in Codecov by Sentry. |
emmatown
force-pushed
the
type-module
branch
5 times, most recently
from
9b80a45
to
4ad986f
Compare
Merged
Andarist
reviewed
Jan 15, 2024
|
|
||
| > If you're just thinking "I want to write code with the native ECMAScript import and export syntax and have my code work for most people", you likely should not use this feature. This feature allows you to build packages that import Node.js ESM only dependencies and therefore only support being imported from ESM in newer versions of Node.js and some bundlers. | ||
|
|
||
| The `type` config being set to `"module"` allows you to generate ECMAScript modules(ESM) compatible with Node.js' implementation of ESM (Node.js ESM), most modern bundlers, etc. |
There was a problem hiding this comment.
shouldnt this mention typeModule and not type with a "module" value?
There was a problem hiding this comment.
"type": "module" has to be set as well, the typeModule experimental flag is mentioned further down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now the output used in
preconstruct devwill only work directly in Node if you're using no non-standard syntax (and following Node's stricter module resolution) or you're using a bundler that will handle it, I'd like to add a loader and fix that in the future.Related: #471, #513