Avoid empty reexport statements in .cjs.mjs files
#558
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 92.11% 92.17% +0.05%
==========================================
Files 41 41
Lines 1979 1981 +2
Branches 584 585 +1
==========================================
+ Hits 1823 1826 +3
+ Misses 146 145 -1
Partials 10 10
☔ View full report in Codecov by Sentry. |
packages/cli/src/utils.ts
Outdated
| @@ -336,6 +336,9 @@ export function dtsTemplate( | |||
| } | |||
|
|
|||
| function getReexportStatement(namedExports: string[], source: string): string { | |||
| if (!namedExports.length) { | |||
| return ""; | |||
There was a problem hiding this comment.
| return ""; | |
| return `import ${source};` |
An entrypoint could (and likely does if it has no exports) have side-effects so we still need to import it.
There was a problem hiding this comment.
Do u always have to be right? :P pushed out this change with extra tests for this
No description provided.