Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade repo to eslint8 ecosystem #422

Merged
merged 5 commits into from Nov 18, 2021

Conversation

gwyneplaine
Copy link
Contributor

This is currently blocking upgrade to eslint 8 for keystone keystonejs/keystone#6769

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

🦋 Changeset detected

Latest commit: 47895b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/eslint-plugin-format-js-tag Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #422 (47895b9) into main (b20d4b9) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   89.83%   89.91%   +0.07%     
==========================================
  Files          32       32              
  Lines        1309     1309              
  Branches      350      350              
==========================================
+ Hits         1176     1177       +1     
+ Misses        128      127       -1     
  Partials        5        5              
Impacted Files Coverage Δ
packages/cli/src/build/config.ts 82.81% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20d4b9...47895b9. Read the comment docs.

@emmatown
Copy link
Member

It looks like TS is failing because the typescript-eslint packages are depending on types that are new in TS 4.5, given 4.5 should be released ~tomorrow, I'll update TS in this repo when that happens and then merge this

@emmatown emmatown merged commit 074bae7 into preconstruct:main Nov 18, 2021
@github-actions github-actions bot mentioned this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants