New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate that types field is on a TypeScript entrypoint (behind a flag) #259
Comments
Ok, seems like I feel however that maybe it should be validated that "types" got used and throw an error on that (in favor of those type files that are auto-generated). This should ofc happen only for TS projects - adding "types" manually should be supported for packages shipping |
Agreed |
Hey folks, what's the status of TypeScript docs advise to add |
There's no real need since TypeScript can already resolve it. Is there are a particular reason you want to add it to the package.json? |
Even to make it easier for other tools. For example, npm marks packages with TS types with a special badge. Compare: |
What Andarist said, and I vaguely remember PRing/patching niche libraries I wanted to use, because old TS couldn't resolve it. |
Okay, sounds good. Happy to accept a PR adding this(behind a flag for now because it would be a breaking change otherwise) |
It's not automatically generated, but even if manually added then it's not validated and cannot be fixed with
preconstruct fix
.The text was updated successfully, but these errors were encountered: