Support import.meta.url in preconstruct dev

preconstruct · Mar 6, 2023 · b14e204 · b14e204
1 parent 57576f9
commit b14e204
Show file tree

Hide file tree

Showing 4 changed files with 101 additions and 0 deletions.
diff --git a/.changeset/shaggy-comics-grab.md b/.changeset/shaggy-comics-grab.md
@@ -0,0 +1,6 @@
+---
+"@preconstruct/cli": patch
+"@preconstruct/hook": patch
+---
+
+Support `import.meta.url` in `preconstruct dev`
diff --git a/packages/cli/src/__tests__/dev.ts b/packages/cli/src/__tests__/dev.ts
@@ -1,6 +1,7 @@
 import spawn from "spawndamnit";
 import path from "path";
 import * as fs from "fs-extra";
+import { pathToFileURL } from "url";
 import * as realFs from "fs";
 import { getFiles, js, testdir, ts, typescriptFixture } from "../../test-utils";
 import dev from "../dev";
@@ -368,3 +369,28 @@ test("flow and .d.ts", async () => {
     export const x = "hello";
   `);
 });
+
+test("import.meta.url", async () => {
+  let tmpPath = await testdir({
+    "package.json": JSON.stringify({
+      name: "pkg",
+      main: "dist/pkg.cjs.js",
+      module: "dist/pkg.esm.js",
+    }),
+    "src/index.js": js`
+                      console.log(import.meta.url);
+                    `,
+  });
+  await dev(tmpPath);
+  // i would require it but i don't want jest to do magical things
+  let { code, stdout, stderr } = await spawn("node", [tmpPath], {
+    env: {
+      PATH: process.env.PATH,
+    },
+  });
+  expect(stderr.toString()).toBe("");
+  expect(code).toBe(0);
+  expect(stdout.toString()).toBe(
+    pathToFileURL(path.join(tmpPath, "src/index.js")).toString() + "\n"
+  );
+});
diff --git a/packages/cli/src/build/__tests__/basic.ts b/packages/cli/src/build/__tests__/basic.ts
@@ -1238,3 +1238,51 @@ test("importing css fails with a nice error", async () => {
     `[Error: 🎁 @scope/test only .ts, .tsx, .js, .jsx, and .json files can be imported but "./blah.css" is imported in "src/index.js"]`
   );
 });
+
+test("import.meta.url", async () => {
+  let dir = await testdir({
+    "package.json": JSON.stringify({
+      name: "@scope/test",
+      main: "dist/scope-test.cjs.js",
+      module: "dist/scope-test.esm.js",
+    }),
+    "src/index.js": ts`
+                      export const a = import.meta.url;
+                    `,
+  });
+  await build(dir);
+  expect(await getDist(dir)).toMatchInlineSnapshot(`
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.cjs.dev.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    'use strict';
+
+    Object.defineProperty(exports, '__esModule', { value: true });
+
+    const a = (typeof document === 'undefined' ? new (require('u' + 'rl').URL)('file:' + __filename).href : (document.currentScript && document.currentScript.src || new URL('dist/scope-test.cjs.dev.js', document.baseURI).href));
+
+    exports.a = a;
+
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.cjs.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    'use strict';
+
+    if (process.env.NODE_ENV === "production") {
+      module.exports = require("./scope-test.cjs.prod.js");
+    } else {
+      module.exports = require("./scope-test.cjs.dev.js");
+    }
+
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.cjs.prod.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    'use strict';
+
+    Object.defineProperty(exports, '__esModule', { value: true });
+
+    const a = (typeof document === 'undefined' ? new (require('u' + 'rl').URL)('file:' + __filename).href : (document.currentScript && document.currentScript.src || new URL('dist/scope-test.cjs.prod.js', document.baseURI).href));
+
+    exports.a = a;
+
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.esm.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    const a = import.meta.url;
+
+    export { a };
+
+  `);
+});
diff --git a/packages/hook/index.js b/packages/hook/index.js
@@ -1,12 +1,33 @@
+"use strict";
 const { addHook } = require("pirates");
 const babel = require("@babel/core");
 const sourceMapSupport = require("source-map-support");
 const path = require("path");
+const url = require("url");
 
 let EXTENSIONS = [".js", ".jsx", ".ts", ".tsx"];
 
 let babelPlugins = [
   require.resolve("@babel/plugin-transform-modules-commonjs"),
+  {
+    visitor: {
+      MemberExpression(path, state) {
+        if (
+          path.node.object.type === "MetaProperty" &&
+          path.node.object.meta.name === "import" &&
+          path.node.object.property.name === "meta" &&
+          !path.node.computed &&
+          path.node.property.name === "url"
+        ) {
+          path.replaceWith(
+            babel.types.stringLiteral(
+              url.pathToFileURL(state.filename).toString()
+            )
+          );
+        }
+      },
+    },
+  },
 ];
 
 exports.___internalHook = (distDir, relativeToRoot, relativeToPkgDir) => {