Fix node: imports (#476)

preconstruct · Jul 14, 2022 · 3930466 · 3930466
1 parent 4ce8cfc
commit 3930466
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 2 deletions.
diff --git a/.changeset/seven-bikes-smash.md b/.changeset/seven-bikes-smash.md
@@ -0,0 +1,5 @@
+---
+"@preconstruct/cli": patch
+---
+
+Using `node:` to import Node builtins no longer triggers a "package is not specified in dependencies or peerDependencies" error
diff --git a/packages/cli/src/build/__tests__/basic.ts b/packages/cli/src/build/__tests__/basic.ts
@@ -1155,3 +1155,45 @@ test("bigint usage", async () => {
 
   `);
 });
+
+test("node: is external", async () => {
+  let dir = await testdir({
+    "package.json": JSON.stringify({
+      name: "@scope/test",
+      main: "dist/scope-test.cjs.js",
+      module: "dist/scope-test.esm.js",
+    }),
+    "src/index.js": ts`
+                      import fs from "node:fs";
+                      fs.writeFileSync("test.txt", "test");
+                    `,
+  });
+  await build(dir);
+  expect(await getDist(dir)).toMatchInlineSnapshot(`
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.cjs.dev.js, dist/scope-test.cjs.prod.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    'use strict';
+
+    var fs = require('node:fs');
+
+    function _interopDefault (e) { return e && e.__esModule ? e : { 'default': e }; }
+
+    var fs__default = /*#__PURE__*/_interopDefault(fs);
+
+    fs__default['default'].writeFileSync("test.txt", "test");
+
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.cjs.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    'use strict';
+
+    if (process.env.NODE_ENV === "production") {
+      module.exports = require("./scope-test.cjs.prod.js");
+    } else {
+      module.exports = require("./scope-test.cjs.dev.js");
+    }
+
+    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ dist/scope-test.esm.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
+    import fs from 'node:fs';
+
+    fs.writeFileSync("test.txt", "test");
+
+  `);
+});
diff --git a/packages/cli/src/build/rollup.ts b/packages/cli/src/build/rollup.ts
@@ -22,8 +22,10 @@ import { EXTENSIONS } from "../constants";
 import { inlineProcessEnvNodeEnv } from "../rollup-plugins/inline-process-env-node-env";
 import normalizePath from "normalize-path";
 
+type ExternalPredicate = (source: string) => boolean;
+
 // this makes sure nested imports of external packages are external
-const makeExternalPredicate = (externalArr: string[]) => {
+const makeExternalPredicate = (externalArr: string[]): ExternalPredicate => {
   if (externalArr.length === 0) {
     return () => false;
   }
@@ -53,8 +55,13 @@ export let getRollupConfig = (
     external.push(...Object.keys(pkg.json.dependencies));
   }
 
+  let wrapExternalPredicate = (inner: ExternalPredicate): ExternalPredicate =>
+    inner;
+
   if (type === "node-dev" || type === "node-prod") {
     external.push(...builtInModules);
+    wrapExternalPredicate = (inner) => (source) =>
+      source.startsWith("node:") || inner(source);
   }
 
   let input: Record<string, string> = {};
@@ -76,7 +83,7 @@ export let getRollupConfig = (
 
   const config: RollupOptions = {
     input,
-    external: makeExternalPredicate(external),
+    external: wrapExternalPredicate(makeExternalPredicate(external)),
     onwarn: (warning) => {
       if (typeof warning === "string") {
         warnings.push(