[dev-launcher] Support react-native-v8 (expo#19117)

# Why another attempt than expo#18151 to support react-native-v8 # How if there's *libv8android.so*, we just use the js executor factory from main ReactNativeHost. for the bundled reanimated in dev-menu, i have a pr to keep jsc in debug build: Kudo/react-native-v8#142 # Test Plan ```sh $ yarn create expo-app -t blank@sdk-46 sdk46v8 $ cd sdk46v8 $ npx expo install react-native-v8 v8-android-jit # add "plugins": ["react-native-v8"] to app.json $ npx expo install expo-dev-client $ npx expo prebuild -p android # patch node_modules/expo-dev-launcher $ npx expo run:android ```
preciofishbone · Sep 26, 2022 · aef26c9 · aef26c9
1 parent f9c2a29
commit aef26c9
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 0 deletions.
diff --git a/packages/expo-dev-launcher/CHANGELOG.md b/packages/expo-dev-launcher/CHANGELOG.md
@@ -14,6 +14,7 @@
 ### 🐛 Bug fixes
 
 - Remove the deprecated `Linking.removeEventListener` in expo-dev-launcher bundle. ([#18939](https://github.com/expo/expo/pull/18939) by [@kudo](https://github.com/kudo))
+- Fixed the incompatibility with react-native-v8 on Android. ([#19117](https://github.com/expo/expo/pull/19117) by [@kudo](https://github.com/kudo))
 
 ### 💡 Others
 

diff --git a/...t-native-64/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt b/...t-native-64/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt
@@ -25,6 +25,11 @@ class DevLauncherReactNativeHostHandler(context: Context) : ReactNativeHostHandl
     val applicationContext = context.applicationContext
 
     SoLoader.init(applicationContext, /* native exopackage */ false)
+    if (SoLoader.getLibraryPath("libv8android.so") != null) {
+      // Assuming V8 overrides the `getJavaScriptExecutorFactory` in the main ReactNativeHost,
+      // return null here to use the default value.
+      return null
+    }
     if (SoLoader.getLibraryPath("libjsc.so") != null) {
       return JSCExecutorFactory(applicationContext.packageName, AndroidInfoHelpers.getFriendlyDeviceName())
     }

diff --git a/...t-native-65/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt b/...t-native-65/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt
@@ -25,6 +25,11 @@ class DevLauncherReactNativeHostHandler(context: Context) : ReactNativeHostHandl
     val applicationContext = context.applicationContext
 
     SoLoader.init(applicationContext, /* native exopackage */ false)
+    if (SoLoader.getLibraryPath("libv8android.so") != null) {
+      // Assuming V8 overrides the `getJavaScriptExecutorFactory` in the main ReactNativeHost,
+      // return null here to use the default value.
+      return null
+    }
     if (SoLoader.getLibraryPath("libjsc.so") != null) {
       return JSCExecutorFactory(applicationContext.packageName, AndroidInfoHelpers.getFriendlyDeviceName())
     }

diff --git a/...t-native-66/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt b/...t-native-66/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt
@@ -25,6 +25,11 @@ class DevLauncherReactNativeHostHandler(context: Context) : ReactNativeHostHandl
     val applicationContext = context.applicationContext
 
     SoLoader.init(applicationContext, /* native exopackage */ false)
+    if (SoLoader.getLibraryPath("libv8android.so") != null) {
+      // Assuming V8 overrides the `getJavaScriptExecutorFactory` in the main ReactNativeHost,
+      // return null here to use the default value.
+      return null
+    }
     if (SoLoader.getLibraryPath("libjsc.so") != null) {
       return JSCExecutorFactory(applicationContext.packageName, AndroidInfoHelpers.getFriendlyDeviceName())
     }

diff --git a/...t-native-67/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt b/...t-native-67/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt
@@ -26,6 +26,11 @@ class DevLauncherReactNativeHostHandler(context: Context) : ReactNativeHostHandl
     val applicationContext = context.applicationContext
 
     SoLoader.init(applicationContext, /* native exopackage */ false)
+    if (SoLoader.getLibraryPath("libv8android.so") != null) {
+      // Assuming V8 overrides the `getJavaScriptExecutorFactory` in the main ReactNativeHost,
+      // return null here to use the default value.
+      return null
+    }
     if (SoLoader.getLibraryPath("libjsc.so") != null) {
       return JSCExecutorFactory(applicationContext.packageName, AndroidInfoHelpers.getFriendlyDeviceName())
     }

diff --git a/...t-native-69/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt b/...t-native-69/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt
@@ -26,6 +26,11 @@ class DevLauncherReactNativeHostHandler(context: Context) : ReactNativeHostHandl
     val applicationContext = context.applicationContext
 
     SoLoader.init(applicationContext, /* native exopackage */ false)
+    if (SoLoader.getLibraryPath("libv8android.so") != null) {
+      // Assuming V8 overrides the `getJavaScriptExecutorFactory` in the main ReactNativeHost,
+      // return null here to use the default value.
+      return null
+    }
     if (SoLoader.getLibraryPath("libjsc.so") != null) {
       return JSCExecutorFactory(applicationContext.packageName, AndroidInfoHelpers.getFriendlyDeviceName())
     }