Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmakebuild.js to spawn with shell: true #325

Merged
merged 3 commits into from
May 16, 2024

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Apr 17, 2024

This fixes #324 - I've tested on a Windows x86_64 and on my MacBook M3 (arm64).

I considered adding it here as well:

return cp.spawn(cmd, args).on('exit', function (code) {

But it seems the only code (currently) calling this of that util is disabled on Windows:

if (platform === 'win32') return process.nextTick(cb)

@kraenhansen kraenhansen mentioned this pull request Apr 17, 2024
7 tasks
@Apollon77
Copy link

Apollon77 commented Apr 20, 2024

I support this fix in general, see my comment below. The reason for this is new security measures in windows itelf. many project run against this these days, including node-red, iobroker and others.

cmakebuild.js Outdated Show resolved Hide resolved
@Apollon77
Copy link

@lovell @ralphtheninja @vweevers Thank you for considering a time near merge and release becaise this blocks many windows useages !

cmakebuild.js Outdated Show resolved Hide resolved
Co-authored-by: Lovell Fuller <lovell@users.noreply.github.com>
Copy link
Member

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@lovell lovell merged commit 93373d0 into prebuild:master May 16, 2024
12 checks passed
@lovell lovell added the semver-patch Bug fixes that are backward compatible label May 16, 2024
@lovell lovell mentioned this pull request May 16, 2024
@lovell
Copy link
Member

lovell commented May 16, 2024

v13.0.1

@kraenhansen kraenhansen deleted the patch-1 branch May 16, 2024 13:18
@Apollon77
Copy link

Thank you very much!!

@Apollon77
Copy link

PS: Validated: Solves the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prebuild --backend cmake-js fails on Windows x86_64
3 participants