-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmakebuild.js to spawn with shell: true
#325
Conversation
I support this fix in general, see my comment below. The reason for this is new security measures in windows itelf. many project run against this these days, including node-red, iobroker and others. |
@lovell @ralphtheninja @vweevers Thank you for considering a time near merge and release becaise this blocks many windows useages ! |
Co-authored-by: Lovell Fuller <lovell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM.
v13.0.1 |
Thank you very much!! |
PS: Validated: Solves the problem |
This fixes #324 - I've tested on a Windows x86_64 and on my MacBook M3 (arm64).
I considered adding it here as well:
prebuild/util.js
Line 20 in af905c7
But it seems the only code (currently) calling this of that util is disabled on Windows:
prebuild/strip.js
Line 6 in af905c7