Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update rollup-plugin-visualizer to latest #611

Merged
merged 8 commits into from Aug 30, 2021

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented May 10, 2021

Upgrading will (eventually) allow us to exclude some portions of the bundle that aren't relevant to users.

TODO:

  • Need a test for the visualizer going forward, as it relies on a pretty sketchy regex replace setup
    • Just that wmr build --visualize outputs a stats.html should be enough. We just need to make sure its assets are inlined properly at build time.
  • Need to bump rollup to >= 2.44 in order to return gzip and/or brotli stats to the user with rollup-plugin-visualizer >= 5

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2021

🦋 Changeset detected

Latest commit: 3b1f456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Size Change: +7.84 kB (+1%)

Total Size: 804 kB

Filename Size Change
examples/demo/dist/alias-outside/index.html 693 B +1 B (0%)
examples/demo/dist/chunks/alias-outside.********.js 139 B +2 B (+1%)
examples/demo/dist/chunks/class-fields.********.js 214 B +3 B (+1%)
examples/demo/dist/chunks/compat.********.js 15.3 kB +2 B (0%)
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB +12 B (+1%)
examples/demo/dist/chunks/index.********.js 201 B -102 B (-34%) 🎉
examples/demo/dist/chunks/json.********.js 239 B +1 B (0%)
examples/demo/dist/chunks/meta-tags.********.js 300 B +1 B (0%)
examples/demo/dist/chunks/prerender.********.js 2.44 kB +1 B (0%)
examples/demo/dist/class-fields/index.html 705 B +2 B (0%)
examples/demo/dist/compat/index.html 1.6 kB +1 B (0%)
examples/demo/dist/env/index.html 780 B +1 B (0%)
examples/demo/dist/error/index.html 709 B +1 B (0%)
examples/demo/dist/files/index.html 742 B +4 B (+1%)
examples/demo/dist/index.********.js 7.66 kB -1 B (0%)
examples/demo/dist/index.html 772 B +2 B (0%)
examples/demo/dist/json/index.html 712 B +1 B (0%)
examples/demo/dist/lazy-and-late/index.html 715 B +1 B (0%)
examples/demo/dist/meta-tags/index.html 780 B -1 B (0%)
packages/wmr/wmr.cjs 766 kB +7.91 kB (+1%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 713 B
examples/demo/dist/assets/Calendar.********.css 702 B
examples/demo/dist/assets/style.********.css 624 B

compressed-size-action

@rschristian rschristian force-pushed the chore/bump-rollup-plugin-visualizer branch 3 times, most recently from dd34d1c to 7fd4e39 Compare May 10, 2021 06:54
@rschristian rschristian force-pushed the chore/bump-rollup-plugin-visualizer branch 2 times, most recently from d4a477b to 1214dea Compare May 27, 2021 03:42
@marvinhagemeister marvinhagemeister force-pushed the chore/bump-rollup-plugin-visualizer branch from 1214dea to c80ecb8 Compare July 5, 2021 21:55
@marvinhagemeister
Copy link
Member

@rschristian hope you don't mind. Took the liberty of updating this PR.

@rschristian
Copy link
Member Author

@marvinhagemeister Oh, of course not. Has anyone ever minded not having to write tests themselves? 😄

I had put this on the back burner as I feel that the regex filtering (the feature gained by updating the visualizer) isn't particularly useful at the moment. A bit unintuitive and filtering doesn't result in the displayed stats updating. Might change in the future though.

Certainly could merge this in now though if you'd like? Nothing's holding it back.

@marvinhagemeister marvinhagemeister force-pushed the chore/bump-rollup-plugin-visualizer branch from c80ecb8 to b291d4f Compare August 29, 2021 22:12
@marvinhagemeister
Copy link
Member

I've found the root cause for why the tests were failing. It looks like the external option during resolution has changed in rollup > 2.43.1. See: rollup/rollup#4021

@marvinhagemeister marvinhagemeister marked this pull request as ready for review August 30, 2021 00:05
@marvinhagemeister marvinhagemeister merged commit 494f933 into main Aug 30, 2021
@marvinhagemeister marvinhagemeister deleted the chore/bump-rollup-plugin-visualizer branch August 30, 2021 00:05
@github-actions github-actions bot mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants