New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update rollup-plugin-visualizer to latest #611
Conversation
🦋 Changeset detectedLatest commit: 3b1f456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +7.84 kB (+1%) Total Size: 804 kB
ℹ️ View Unchanged
|
dd34d1c
to
7fd4e39
Compare
d4a477b
to
1214dea
Compare
1214dea
to
c80ecb8
Compare
@rschristian hope you don't mind. Took the liberty of updating this PR. |
@marvinhagemeister Oh, of course not. Has anyone ever minded not having to write tests themselves? 😄 I had put this on the back burner as I feel that the regex filtering (the feature gained by updating the visualizer) isn't particularly useful at the moment. A bit unintuitive and filtering doesn't result in the displayed stats updating. Might change in the future though. Certainly could merge this in now though if you'd like? Nothing's holding it back. |
Looks like they made a breaking change in a minor release: rollup/rollup#4021
c80ecb8
to
b291d4f
Compare
I've found the root cause for why the tests were failing. It looks like the |
Upgrading will (eventually) allow us to exclude some portions of the bundle that aren't relevant to users.
TODO:
wmr build --visualize
outputs astats.html
should be enough. We just need to make sure its assets are inlined properly at build time.rollup
to >= 2.44 in order to return gzip and/or brotli stats to the user withrollup-plugin-visualizer
>= 5