Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI (obsolete lockfile) #431

Open
wants to merge 1 commit into
base: react-1.2.x
Choose a base branch
from
Open

Fix CI (obsolete lockfile) #431

wants to merge 1 commit into from

Conversation

XantreDev
Copy link
Contributor

@XantreDev XantreDev commented Nov 5, 2023 •
edited

Updated lockfile to fix CI

Partially based on #391

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2023 •
edited

⚠️ No Changeset found

Latest commit: 94b7768

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XantreDev XantreDev mentioned this pull request Nov 5, 2023
Open
@XantreDev XantreDev force-pushed the react-1.2.x-update-lockfile branch 3 times, most recently from 73d851a to 78aa455 Compare November 6, 2023 07:58
@XantreDev
Copy link
Contributor Author

@robertknight I've added ci for target branch

rschristian
rschristian requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be targetting main, not the one-off branch (that I'm still not sure we'll support a release for). Everything in the workflow files looks like it should be reverted.

.github/workflows/compressed-size.yml Outdated
@@ -8,18 +8,17 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the theme, please don't alter things unless absolutely necessary.

The goal with all PRs is to try to keep the diff concise and targeted -- it makes it so much easier to navigate the blame later on if needs be. Sometimes it can make sense to toss a bunch of changes together, like if you were really altering the CI, but updating actions is not necessary from what I can see nor within the scope of bumping the lock file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CI is needed to ensure that all works fine in the branch, also it's useful to release new version with changesets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use changesets for publishing, and again, that fix should be a one-off. We really don't want to be supporting 1.2.x beyond that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XantreDev @rschristian