feat: Add popover types #4378
Merged
feat: Add popover types #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be all bueno here, rts might need a fix up for the reflected attrs, depending on whether we consider that an issue |
lukewarlow
reviewed
May 10, 2024
| | 'toggle' | ||
| | undefined | ||
| | SignalLike<'hide' | 'show' | 'toggle' | undefined>; | ||
| popoverTargetAction?: |
There was a problem hiding this comment.
This will set the property whereas popoverTarget will set the attribute due to the fact the property is actually popoverTargetElement (and takes an element reference rather than an idref string).
This mismatch might be confusing to people?
There was a problem hiding this comment.
I've just remembered I think the property for action reflects to the content attribute so it might be fine?
There was a problem hiding this comment.
Yep, should actually be okay because of that.
JoviDeCroock
approved these changes
May 11, 2024
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
popover="hint"hasn't yet landed in the spec and as such is perhaps questionable. It seems likely that it will and I figure jumping the gun on implementation might be slightly better than needing to be pinged to add it later (as it's not a spec I'm watching), but happy to remove it if it's undesirable.