Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major(core): remove px suffixing from core #4358

Open
wants to merge 4 commits into
base: breaking-changes-11
Choose a base branch
from
Open

major(core): remove px suffixing from core #4358

wants to merge 4 commits into from
+232 −28

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 29, 2024 •
edited

This removes the px suffixing from Preact core and adds it to compat, we could allow a lot of this functionality to be added from snippets.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-8.05ms - +8.05ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -3% - +1% (-0.50ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-3.00ms - +1.42ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - -0% (-0.42ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-1.04ms - +1.12ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +2% (-0.09ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +4% (-0.47ms - +1.08ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +2% (-0.26ms - +0.65ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-0.50ms - +0.29ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +2% (-0.00ms - +0.06ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.05ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local880.83ms - 894.11ms-unsure 🔍
-1% - +1%
-8.05ms - +8.05ms
preact-main882.93ms - 892.01msunsure 🔍
-1% - +1%
-8.05ms - +8.05ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.75ms - 26.75ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main26.75ms - 26.75msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.67ms - 16.92ms-unsure 🔍
-3% - +1%
-0.50ms - +0.12ms
preact-main16.70ms - 17.26msunsure 🔍
-1% - +3%
-0.12ms - +0.50ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.75ms - 1.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.72ms - 76.58ms-unsure 🔍
-4% - +2%
-3.00ms - +1.42ms
preact-main74.43ms - 78.44msunsure 🔍
-2% - +4%
-1.42ms - +3.00ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.14ms - 14.67ms-unsure 🔍
-3% - +2%
-0.50ms - +0.29ms
preact-main14.22ms - 14.80msunsure 🔍
-2% - +3%
-0.29ms - +0.50ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.36ms - 16.51ms-unsure 🔍
-2% - -0%
-0.42ms - +0.00ms
preact-main16.45ms - 16.84msunsure 🔍
-0% - +3%
-0.00ms - +0.42ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.86ms - 4.86ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main4.86ms - 4.86msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local81.27ms - 82.93ms-unsure 🔍
-1% - +1%
-1.04ms - +1.12ms
preact-main81.37ms - 82.74msunsure 🔍
-1% - +1%
-1.12ms - +1.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.70ms - 3.75ms-unsure 🔍
-0% - +2%
-0.00ms - +0.06ms
preact-main3.68ms - 3.72msunsure 🔍
-2% - +0%
-0.06ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.07ms - 30.92ms-unsure 🔍
-3% - +2%
-0.81ms - +0.52ms
preact-main30.13ms - 31.15msunsure 🔍
-2% - +3%
-0.52ms - +0.81ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local40.04ms - 42.11ms-unsure 🔍
-2% - +5%
-0.73ms - +2.10ms
preact-main39.42ms - 41.35msunsure 🔍
-5% - +2%
-2.10ms - +0.73ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.57ms - 28.89ms-unsure 🔍
-1% - +0%
-0.31ms - +0.12ms
preact-main28.68ms - 28.97msunsure 🔍
-0% - +1%
-0.12ms - +0.31ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.36ms - 27.12ms-unsure 🔍
-2% - +2%
-0.61ms - +0.47ms
preact-main26.42ms - 27.19msunsure 🔍
-2% - +2%
-0.47ms - +0.61ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local28.06ms - 30.31ms-unsure 🔍
-7% - +4%
-2.08ms - +1.22ms
preact-main28.42ms - 30.82msunsure 🔍
-4% - +7%
-1.22ms - +2.08ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local25.40ms - 26.58ms-unsure 🔍
-6% - +1%
-1.56ms - +0.31ms
preact-main25.89ms - 27.34msunsure 🔍
-1% - +6%
-0.31ms - +1.56ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.84ms-unsure 🔍
-5% - +2%
-0.09ms - +0.04ms
preact-main1.78ms - 1.87msunsure 🔍
-2% - +5%
-0.04ms - +0.09ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.06ms - 1.12ms-unsure 🔍
-5% - +4%
-0.05ms - +0.04ms
preact-main1.06ms - 1.13msunsure 🔍
-4% - +5%
-0.04ms - +0.05ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.15ms - 28.63ms-unsure 🔍
-2% - +4%
-0.47ms - +1.08ms
preact-main27.35ms - 27.83msunsure 🔍
-4% - +2%
-1.08ms - +0.47ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.02ms - 30.88ms-unsure 🔍
-1% - +2%
-0.26ms - +0.65ms
preact-main30.11ms - 30.40msunsure 🔍
-2% - +1%
-0.65ms - +0.26ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.69ms - 3.69ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.69ms - 3.69msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Size Change: -446 B (0%)

Total Size: 60.6 kB

Filename Size Change
compat/dist/compat.js 4.19 kB +102 B (2%)
compat/dist/compat.module.js 4.12 kB +109 B (2%)
compat/dist/compat.umd.js 4.25 kB +104 B (2%)
dist/preact.js 4.53 kB -80 B (1%)
dist/preact.min.js 4.57 kB -77 B (1%)
dist/preact.min.module.js 4.56 kB -79 B (1%)
dist/preact.min.umd.js 4.59 kB -78 B (1%)
dist/preact.module.js 4.54 kB -77 B (1%)
dist/preact.umd.js 4.6 kB -77 B (1%)
jsx-runtime/dist/jsxRuntime.js 878 B -98 B (11%) 👏
jsx-runtime/dist/jsxRuntime.module.js 852 B -97 B (11%) 👏
jsx-runtime/dist/jsxRuntime.umd.js 958 B -98 B (10%) 👏
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.63 kB 0 B
debug/dist/debug.module.js 3.63 kB 0 B
debug/dist/debug.umd.js 3.71 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock marked this pull request as ready for review April 29, 2024 15:37
@coveralls
Copy link

coveralls commented Apr 29, 2024 •
edited

Coverage Status

coverage: 99.609%. remained the same
when pulling 7435228 on remove-px-suffixing
into 613cacc on main.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit Awaiting requested review from developit

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoviDeCroock @coveralls