More Preact X compat things™ #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
requested review from
lukeed and
developit
and removed request for
lukeed
developit
reviewed
Mar 11, 2019
| @@ -92,8 +102,6 @@ | |||
| "optimize-css-assets-webpack-plugin": "^5.0.1", | |||
| "ora": "^3.0.0", | |||
| "postcss-loader": "^3.0.0", | |||
| "preact": "^8.1.0", | |||
There was a problem hiding this comment.
Does this break prerendering?
There was a problem hiding this comment.
it shouldn't, as a peerDep it should resolve fine
| @@ -6,7 +6,7 @@ const SizePlugin = require('size-plugin'); | |||
| const autoprefixer = require('autoprefixer'); | |||
| const requireRelative = require('require-relative'); | |||
| const MiniCssExtractPlugin = require('mini-css-extract-plugin'); | |||
| const FixStyleOnlyEntriesPlugin = require('webpack-fix-style-only-entries'); | |||
There was a problem hiding this comment.
Bah. Will the fix still let this strip out the Webpack modules that have nothing in them? They should have no originalModule since they're not from an ESM source?
There was a problem hiding this comment.
should fix it, just commented it out for now, because it broke the tests
ForsakenHarmony
commented
Mar 13, 2019
packages/cli/package.json
Outdated
| "ejs-loader": "^0.3.0", | ||
| "esm": "^3.2.7", | ||
| "esm": "<=3.2.14", |
There was a problem hiding this comment.
developit
reviewed
Mar 15, 2019
| @@ -61,11 +61,17 @@ module.exports = function(env) { | |||
| let cliNodeModules = findAllNodeModules(__dirname); | |||
| let nodeModules = [...new Set([...userNodeModules, ...cliNodeModules])]; | |||
|
|
|||
| let compat = 'preact-compat'; | |||
| try { | |||
| requireRelative.resolve('preact/compat', cwd); | |||
There was a problem hiding this comment.
Should we be trying to resolve this only to node_modules/preact/compat? I think this will resolve to node_modules/preact/compat/dist/compat.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.