Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: push-manifest.json CSS asset type #1736

Merged
merged 5 commits into from Nov 18, 2022
Merged

fix: push-manifest.json CSS asset type #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61985fc
fix: CSS in push-manifest was labeled as a script
rschristian Aug 16, 2022
5d0d827
docs: Adding changeset
rschristian Aug 16, 2022
4b2ec87
refactor: Skips over already set file attrs when generating push-mani…
rschristian Aug 16, 2022
6f16cea
Merge branch 'master' into fix/push-manifest-css-type
rschristian Aug 18, 2022
7723a12
Merge branch 'master' into fix/push-manifest-css-type
rschristian Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-poets-sneeze.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

Fix for CSS assets sometimes being mistakenly labeled as 'scripts' in the push-manifest.
3 changes: 2 additions & 1 deletion packages/cli/lib/lib/webpack/create-load-manifest.js
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ module.exports = (assets, namedChunkGroups, isProd) => {
const routeJs = assets[`${route}.js`];

routeManifest[routeJs] = { type: 'script', weight: 0.9 };
if (routeCss) routeManifest[routeCss] = { type: 'script', weight: 0.9 };
if (routeCss) routeManifest[routeCss] = { type: 'style', weight: 0.9 };

const path = route.replace(/^route-/, '/').replace(/^\/home/, '/');

Expand All @@ -52,6 +52,7 @@ module.exports = (assets, namedChunkGroups, isProd) => {
asyncFiles.chunks.forEach(asset => {
asset.files = asset.files || [];
asset.files.forEach(file => {
if (routeManifest[file]) return;
if (/\.css$/.test(file)) {
routeManifest[file] = { type: 'style', weight: 0.9 };
} else if (/\.js$/.test(file)) {
Expand Down