chore: Misc cleaning #1659
chore: Misc cleaning #1659
Conversation
🦋 Changeset detectedLatest commit: 00a3cd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
chore/misc-cleaning
branch
from
f1422ed
to
3488f90
Compare
| it.skip('should hydrate routes progressively.', async () => { | ||
| let dir = await subject('progressive-hydration'); | ||
| await build(dir); | ||
| const server = getServer(join(dir, 'build'), PORT); | ||
|
|
||
| // let page = await loadPage(chrome, `http://127.0.0.1:${PORT}/`); | ||
| const page = await chrome.newPage(); | ||
|
|
||
| page.on('console', consoleMessage => { | ||
| // eslint-disable-next-line | ||
| console[consoleMessage.type()](consoleMessage.text()); | ||
| }); | ||
|
|
||
| await page.goto(`http://127.0.0.1:${PORT}/`); | ||
|
|
||
| // await waitUntilExpression(page, `window.booted`); | ||
| await sleep(500); | ||
|
|
||
| const mutations = await page.evaluate('window.mutations'); | ||
|
|
||
| expect(mutations).toHaveLength(0); | ||
|
|
||
| server.server.close(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Has been skipped since it was added: #957
| @@ -1,13 +1,16 @@ | |||
| const { join } = require('path'); | |||
| const { mkdirSync, symlinkSync } = require('fs'); | |||
| const { mkdir, symlink } = require('fs').promises; | |||
There was a problem hiding this comment.
Should be ever so slightly faster with promises, and everything is already async anyways.
| @@ -156,14 +158,12 @@ async function clientConfig(env) { | |||
| }; | |||
| } | |||
|
|
|||
| function getBabelEsmPlugin(config) { | |||
There was a problem hiding this comment.
Besides a few spots in client-config, everywhere else we use env, rather than config. This has been slightly awkward to follow as I've done v5 stuff.
| new webpack.DefinePlugin({ | ||
| 'process.env.ADD_SW': config.sw, | ||
| 'process.env.PRERENDER': config.prerender, | ||
| }), |
There was a problem hiding this comment.
Values are duplicated with prod config, so they can be moved up to common.
rschristian
force-pushed
the
chore/misc-cleaning
branch
from
3488f90
to
e5ae032
Compare
| @@ -8,7 +8,7 @@ module.exports = (assets, isESMBuild = false, namedChunkGroups) => { | |||
| styles = []; | |||
| for (let filename in assets) { | |||
| if (!/\.map$/.test(filename)) { | |||
| if (/route-/.test(filename)) { | |||
| if (/^route-.*\.js$/.test(filename)) { | |||
There was a problem hiding this comment.
This created some junk output in push-manifest.json when ESM is disabled, like in our test suite. Wouldn't have ever been a problem, as these junk "routes" would never match to a URL when building the HTML, but certainly looked odd if any user took a peek.
{
"/": {
"bundle.2da73.css": {
"type": "style",
"weight": 1
},
"bundle.44866.js": {
"type": "script",
"weight": 1
},
"route-home.chunk.3cec8.js": {
"type": "script",
"weight": 0.9
},
"route-home.chunk.bcb8a.css": {
"type": "style",
"weight": 0.9
}
},
"/.chunk.bcb8a.css": {
"bundle.2da73.css": {
"type": "style",
"weight": 1
},
"bundle.44866.js": {
"type": "script",
"weight": 1
},
"route-home.chunk.bcb8a.css": {
"type": "script",
"weight": 0.9
}
},
"/profile.chunk.6dd80.css": {
"bundle.2da73.css": {
"type": "style",
"weight": 1
},
"bundle.44866.js": {
"type": "script",
"weight": 1
},
"route-profile.chunk.6dd80.css": {
"type": "script",
"weight": 0.9
}
},
"/profile": {
"bundle.2da73.css": {
"type": "style",
"weight": 1
},
"bundle.44866.js": {
"type": "script",
"weight": 1
},
"route-profile.chunk.ddf94.js": {
"type": "script",
"weight": 0.9
},
"route-profile.chunk.6dd80.css": {
"type": "style",
"weight": 0.9
}
}
}
Sorry, yet another bit of backporting changes made in the v4/webpack 5 branches.
push-manifestcreation in non-esm environments (though this shouldn't have ever caused an actual issue, see below for example)Shouldn't be any functional changes or fixes.