Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating webpack-dev-server #1646

Merged
merged 2 commits into from Jan 31, 2022
Merged

chore: Updating webpack-dev-server #1646

merged 2 commits into from Jan 31, 2022

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

Chore

Did you add tests for your changes?

No

Summary

Bumps webpack-dev-server to latest. It works with v4 just fine.

Does this PR introduce a breaking change?

Shouldn't, no.

The output looks a tad different now, thought I'd take screenshots for comparison's sake:

Old New

@rschristian rschristian requested a review from a team as a code owner January 30, 2022 06:53
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2022

🦋 Changeset detected

Latest commit: c0330ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ForsakenHarmony ForsakenHarmony merged commit e98994a into master Jan 31, 2022
@ForsakenHarmony ForsakenHarmony deleted the chore/dev-server branch January 31, 2022 13:51
@preact-bot preact-bot mentioned this pull request Jan 31, 2022
rschristian added a commit that referenced this pull request Jan 31, 2022
rschristian added a commit that referenced this pull request Jan 31, 2022
* chore: Updating webpack-dev-server (#1646)

* test: Misc changes to test suite

* refactor: Updating prerender-provider

* fix: Temp(?) workaround for Critters not deduping styles

* test: Updating tests

* docs: Adding changeset

* fix: Bumping critters

* junk: Debugging CI

* chore: Bumping critters-webpack

* ci: Fixing PnP test action

* chore: Bumping critters

* test: Updating custom-template tests

* test: Updating sourcemap file size comparision

* test: Custom assertion as key matching was difficult to debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants