Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Python 3.7 to Travis CI #789

Merged
merged 4 commits into from
Jul 8, 2018
Merged

Added Python 3.7 to Travis CI #789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04933cd
Added Python 3.7 to Travis CI
expobrain Jul 2, 2018
cec67bb
Fixed PyYAML version
expobrain Jul 6, 2018
2a46658
Fixed Travis setup for python 3.7
expobrain Jul 6, 2018
e4502b7
Removed PyYAML version
expobrain Jul 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ matrix:
python: 3.6
- env: TOXENV=pypy
python: pypy2.7-5.10.0
- env: TOXENV=py37
python: 3.7-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7-dev is 3.7a4 which is not much like 3.7.0 final

You can read more about my writeup about this: https://github.com/deadsnakes/travis-ci-python3.7-example#travis-ci-python37-example

install: pip install coveralls tox
script: tox
before_install:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
'cfgv>=1.0.0',
'identify>=1.0.0',
'nodeenv>=0.11.1',
'pyyaml',
'pyyaml>=4.2b4',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyyaml 4.x is very much in flux, and pre-commit works fine with the 3.x version

Fortunately, there's supposed to be a 3.13 release that comes out today -- but isn't out yet yaml/pyyaml#193 (comment)

'six',
'toml',
'virtualenv',
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tox]
project = pre_commit
# These should match the travis env list
envlist = py27,py35,py36,pypy
envlist = py27,py35,py36,py37,pypy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when adding py37, we can probably remove py35 -- we don't have any python3.5 specific code and I want to keep travis-ci fast :)


[testenv]
deps = -rrequirements-dev.txt
Expand Down