feat: utilize cpanminus for perl dependencies if available #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanminus is already available in the Windows Perl distribution, but was missing from the runner for Ubuntu. This updates the runner for the perl jobs to make cpanm available.
cpanminus is broadly compatible with our syntax use of cpan, but can offer additional benefits such as Pkg::Name@Version definitions, as well as built-in modules to reduce the environment requirements on the system when resolving dependencies. Tests have been updated to ensure functionality works with either utility.
Ensure perl dependencies that use Pkg::Name@Version definitions work with the cpanm utility.
|
why would one want to use this? I'm inclined to decline unless there's a very good reason and that should start with an issue first rather than a pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpanminus is broadly compatible with our syntax use of cpan, but can offer additional benefits such as
Pkg::Name@Versiondefinitions, as well as built-in modules to reduce the environment requirements on the system when resolving dependencies.This PR updates the perl dependency resolver to use
cpanmif available in the environment. Tests have been updated to ensure operation with either utility, and the Github Actions workflow updated to make the utility available on Ubuntu runners (being already provided in the Windows Perl distribution).