Fix URL links of logs in Github Actions #3185
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
In GitHub Actions the URL generated from the following log output is not parsed correctly because of the trailing period(.)
logger.info(f'Initializing environment for {repo}.')
and it leads to a 404/Not Found page.These are some examples:
The Effect
Having a broken link in the logs output undermines the project's credibility and could frustrate users. It's unfortunate because "pre-commit" is a widely-used and highly maintained project.
The Fix
The PR just removes the trailing period from the log output.
I believe this is a useful change because it doesn't remove any information while it restores the functionality of the URL links in GitHub Actions console.