feat: add options for disabling venv in python #3173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
absolutely not. this bypasses a core promise of pre-commit that it will never touch your system packages |
|
how about "cloning" the current virtual env (or system) to the newly venv, this ensures that it does not affect the system level packages and also resolove the dependency problems (if the dependencty can be found on system packages but not Pypi). A similar solution would be like this https://allwin-raju-12.medium.com/cloning-or-copying-a-virtual-environment-7d1efffccac6 |
|
no, pre-commit only installs from it's config file otherwise caching is intractable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, the dependencies we need are not available on PyPI but are bundled within an image, such as the Arm64 version of Nvidia/TensorRT, which does not offer a wheel file. When using virtualenv, it becomes impossible to locate this package. This PR introduces an option allowing users to use the current Python Environment directly. This is particularly beneficial in CI/CD scenarios.