New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 'download' language for fetching pre-built binaries #3020
base: main
Are you sure you want to change the base?
Conversation
please no pathlib, dataclasses, or backslashes -- really you probably don't need any classes at all. I'm also not sure why the strange sha256 -- use hexdigest which is way more standardized. there's a lot of code here and almost zero tests so it's not in a reviewable state -- please convert your PR to draft until you're ready for a first round |
What do you mean by
The " the strange sha256" is subresource integrity. What do you mean by "no backslashes"? |
your code has a bunch of classes with nontrivial methods -- simple plain-old-data classes is preferred -- check the approaches used by most of the rest of the codebase
just because it is standardized doesn't mean it is good -- we aren't optimizing for http headers where characters are at a minimum so use normal hexdigest which is far more common and much easier to compute
your source code contains many very very ugly backslashes |
This commit implements pre-commit#1453 (comment)
@asottile, normal checksum, i.e. the output from |
what do you mean yes they are |
Ah never mind, for some reason I thought |
I recently build something similar that has a format I was pretty happy with -- might be able to use that format or similar here: https://github.com/asottile/setuptools-download |
@asottile , do you have a preferred way of handling the different OS and architecture? |
setuptools-download handles that with |
This commit implements #1453 (comment)