Warn if the fsmonitor-daemon is running #2891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detection could be better, but it works, and it is only a warning, doesn’t have to be perfect.
for more information, see https://pre-commit.ci
asottile
reviewed
May 18, 2023
pre_commit/staged_files_only.py
Outdated
Comment on lines
52
to
53
| if cmd_output('git', 'fsmonitor--daemon', 'status')[1].startswith('fsmonitor-daemon is watching'): | ||
| logger.warning('The fsmonitor-daemon is running; a bug in the fsmonitor-daemon sometimes causes data loss when run with pre-commit.') |
There was a problem hiding this comment.
this will break on old versions of git
this will also add this subprocess overhead to every execution -- ~20ms on my machine
There was a problem hiding this comment.
this will break on old versions of git
Good point, switched it to checking for the return code.
this will also add this subprocess overhead to every execution -- ~20ms on my machine
I added two extra checks, a platform check, since it’s only available on Windows & macOS, and a check for the ipc file that should by default be there, although it’s seems to be possible to change it on macOS. Does this speed it up enough?
|
@asottile Is this okay? Do I need to write tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less extreme than #2890.