Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect aliases SKIP when installing environments #2479

Closed
wants to merge 1 commit into from
Closed

respect aliases SKIP when installing environments #2479

wants to merge 1 commit into from

Conversation

kmARC
Copy link
Contributor

@kmARC kmARC commented Aug 10, 2022

Fixes #2478

asottile
asottile reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just future open source advice, don't make PRs from your main branch as it makes it significantly more difficult to review / fix

tests/commands/run_test.py
Comment on lines 644 to +650

ret, printed = _do_run(
cap_out, store, repo_with_passing_hook,
run_opts(all_files=True),
{'SKIP': 'skipme-1'},
)
assert ret == 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test now validates two separate things -- it should be two separate tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just future open source advice, don't make PRs from your main branch as it makes it significantly more difficult to review / fix

Sure. I was in the gerrit workflow mindset.

I can put it in a separate test method.

I see the CI failing, should I rebase on v2.20.0 or is this fine?

@kmARC
Copy link
Contributor Author

kmARC commented Aug 11, 2022

I am closing this PR and will open one from our company GH account.

@kmARC kmARC closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SKIP skips invocation by alias but doesn't skip "Installing environment"
2 participants
@kmARC @asottile