New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fail_fast on check level #2097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just one small thing
also a tip for the future, it's usually best to do feature development on a separate branch from master
that way it's easier for me to help edit code if needed
pre_commit/clientlib.py
Outdated
@@ -78,6 +78,7 @@ def _make_argparser(filenames_help: str) -> argparse.ArgumentParser: | |||
cfgv.Optional('require_serial', cfgv.check_bool, False), | |||
cfgv.Optional('stages', cfgv.check_array(cfgv.check_one_of(C.STAGES)), []), | |||
cfgv.Optional('verbose', cfgv.check_bool, False), | |||
cfgv.Optional('fail_fast', cfgv.check_bool, False), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this up next to always_run
(to group related attributes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing!
Sure! Tnx for the tip |
@asottile Noticed that two jobs have failed but not sure how can I resolve those issues, please let me know if there is something I can do |
should be fixed on master -- please try rebasing |
That resolved the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now started using this, and it works exactly as you'd expect. Thank you ❤️ |
This PR adds support for fail_fast on per-hook level. Additional test created to cover new use case, in addition to that the old test was updated due to the change in Hook class (added fail_fast attribute).
Closes #1143